Skip to content

Commit a0011b2

Browse files
authored
Merge branch 'main' into jacky-deadlock-patch
2 parents 8833f67 + 6e2bc1a commit a0011b2

File tree

2 files changed

+1
-12
lines changed

2 files changed

+1
-12
lines changed

src/replit_river/server_session.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,6 @@ async def _handle_messages_from_ws(self, tg: asyncio.TaskGroup) -> None:
145145
)
146146
await add_msg_to_stream(msg, stream)
147147
else:
148-
# TODO(dstewart) This looks like it opens a new call to handler
149-
# on ever ws message, instead of demuxing and
150-
# routing.
151148
_stream = await self._open_stream_and_call_handler(msg, tg)
152149
if not stream:
153150
async with self._stream_lock:

src/replit_river/server_transport.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -303,15 +303,7 @@ async def _establish_handshake(
303303
)
304304
raise SessionStateMismatchException(message)
305305

306-
# from this point on, we're committed to connecting
307-
session_id = handshake_request.sessionId
308-
handshake_response = await self._send_handshake_response(
309-
request_message,
310-
HandShakeStatus(ok=True, sessionId=session_id),
311-
websocket,
312-
)
313-
314-
return handshake_request, handshake_response
306+
return handshake_request, handshake_response
315307

316308
async def _delete_session(self, session: Session) -> None:
317309
async with self._session_lock:

0 commit comments

Comments
 (0)