None of these were async either

Author: blast-hardcheese

src/replit_river/client_session.py

@@ -147,7 +147,7 @@ async def _handle_messages_from_ws(self) -> None:
                         case other:
                             assert_never(other)
 
-                    await self._buffer.remove_old_messages(
+                    self._buffer.remove_old_messages(
                         self._seq_manager.receiver_ack,
                     )
                     self._reset_session_close_countdown()

src/replit_river/message_buffer.py

@@ -47,13 +47,13 @@ def peek(self) -> TransportMessage | None:
             return None
         return self.buffer[0]
 
-    async def remove_old_messages(self, min_seq: int) -> None:
+    def remove_old_messages(self, min_seq: int) -> None:
         """Remove messages in the buffer with a seq number less than min_seq."""
         self.buffer = [msg for msg in self.buffer if msg.seq >= min_seq]
         async with self._space_available_cond:
             self._space_available_cond.notify_all()
 
-    async def close(self) -> None:
+    def close(self) -> None:
         """
         Closes the message buffer and rejects any pending put operations.
         """

src/replit_river/server_session.py

@@ -136,7 +136,7 @@ async def _handle_messages_from_ws(self, tg: asyncio.TaskGroup) -> None:
                             pass
                         case other:
                             assert_never(other)
-                    await self._buffer.remove_old_messages(
+                    self._buffer.remove_old_messages(
                         self._seq_manager.receiver_ack,
                     )
                     self._reset_session_close_countdown()

src/replit_river/session.py

@@ -303,7 +303,7 @@ async def close(self) -> None:
 
             await self.close_websocket(self._ws_wrapper, should_retry=False)
 
-            await self._buffer.close()
+            self._buffer.close()
 
             # Clear the session in transports
             await self._close_session_callback(self)

tests/test_message_buffer.py

@@ -45,7 +45,7 @@ async def put_messages() -> None:
         # Wait for the put call to return.
         await sync_events.get()
         assert len(buffer.buffer) == 1
-        await buffer.remove_old_messages(i)
+        buffer.remove_old_messages(i)
 
     await background_puts