Skip to content

Commit c555a53

Browse files
authored
Don't include session id and connect id in span names (#307)
## Why High cardinality in span names, should be enough as attributes ## What changed Change span names for river session and connection to exclude ids ## Versioning - [ ] Breaking protocol change - [x] Breaking ts/js API change <!-- Kind reminder to add tests and updated documentation if needed -->
1 parent 2f005b5 commit c555a53

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tracing/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export function createSessionTelemetryInfo(
4949
: context.active();
5050

5151
const span = tracer.startSpan(
52-
`river.session.${sessionId}`,
52+
`river.session`,
5353
{
5454
attributes: {
5555
component: 'river',
@@ -72,7 +72,7 @@ export function createConnectionTelemetryInfo(
7272
info: TelemetryInfo,
7373
): TelemetryInfo {
7474
const span = tracer.startSpan(
75-
`connection ${connection.id}`,
75+
`river.connection`,
7676
{
7777
attributes: {
7878
component: 'river',

0 commit comments

Comments
 (0)