chore: resolve clippy warnings

Author: replydev

src/arguments/add.rs

@@ -80,7 +80,7 @@ impl SubcommandExecutor for AddArgs {
 
 fn get_from_args(matches: AddArgs) -> color_eyre::Result<OTPElement> {
     let secret = rpassword::prompt_password("Insert the secret: ").map_err(ErrReport::from)?;
-    map_args_to_code(secret, matches).map_err(ErrReport::from)
+    map_args_to_code(secret, matches)
 }
 
 fn map_args_to_code(secret: String, matches: AddArgs) -> Result<OTPElement> {

src/arguments/extract.rs

@@ -48,15 +48,17 @@ impl SubcommandExecutor for ExtractArgs {
 }
 
 fn filter_extract(args: &ExtractArgs, index: usize, code: &OTPElement) -> bool {
-    let match_by_index = args.index.map_or(true, |i| i == index);
+    let match_by_index = args.index.is_none_or(|i| i == index);
 
-    let match_by_issuer = args.issuer.as_ref().map_or(true, |issuer| {
-        code.issuer.to_lowercase() == issuer.to_lowercase()
-    });
+    let match_by_issuer = args
+        .issuer
+        .as_ref()
+        .is_none_or(|issuer| code.issuer.to_lowercase() == issuer.to_lowercase());
 
-    let match_by_label = args.label.as_ref().map_or(true, |label| {
-        code.label.to_lowercase() == label.to_lowercase()
-    });
+    let match_by_label = args
+        .label
+        .as_ref()
+        .is_none_or(|label| code.label.to_lowercase() == label.to_lowercase());
 
     match_by_index && match_by_issuer && match_by_label
 }

src/arguments/passwd.rs

@@ -1,5 +1,4 @@
 use clap::Args;
-use color_eyre::eyre::ErrReport;
 use zeroize::Zeroize;
 
 use crate::{otp::otp_element::OTPDatabase, utils};
@@ -12,9 +11,7 @@ pub struct PasswdArgs;
 impl SubcommandExecutor for PasswdArgs {
     fn run_command(self, mut database: OTPDatabase) -> color_eyre::Result<OTPDatabase> {
         let mut new_password = utils::verified_password("New password: ", 8);
-        database
-            .save_with_pw(&new_password)
-            .map_err(ErrReport::from)?;
+        database.save_with_pw(&new_password)?;
         new_password.zeroize();
         Ok(database)
     }

src/path.rs

@@ -36,7 +36,6 @@ fn get_default_db_path() -> PathBuf {
     let home_path = home_dir().map(|path| path.join(HOME_PATH));
 
     data_dir()
-        .map(PathBuf::from)
         .map(|p| p.join(XDG_PATH))
         .inspect(|xdg| {
             if !xdg.exists() {