Better `otpuri` parsing

[brian6932]

#157 (comment).

"otpauth://$TYPE/$ISSUER:$LABEL?algorithm=$ALGORITHM&digits=$DIGITS&issuer=$ISSUER&period=$PERIOD&secret=$SECRET"

Minor issue with the current parser's that $ISSUER:$LABEL gets set as issuer instead of split into the right variables, if an issuer query param's detected, that should probably take precedence.

The : should both be accounted for when URI encoded (%3a/%3A), and normally.

[Izzy-CodersPlanet]

Nice issue! 🚀 Just testing GitHub Achievements.

[replydev]

Hi @brian6932, seems that I cannot reproduce this issue.

I tried with the provided example, changing only the secret and this is what I get:

Can you provide further info?

[brian6932]

otpauth://totp/foo%3abar?issuer=foo&secret=JBSWY3DPEHPK3PXP

Label should be bar.

---

otpauth://totp/foo:bar?issuer=foo&secret=JBSWY3DPEHPK3PXP

This works as expected.

[replydev]

Thanks @brian6932, I have added some unit tests and now the parsing is correct from the example you provided.

Feel free to report other OTP Uri parsing issues, using the debug build from this PR #551.

Otherwise I will merge this PR tomorrow.