fixed test case for [email protected]; add debug;

Author: fengmk2

lib/gitlab.js

@@ -10,6 +10,7 @@
  * Module dependencies.
  */
 
+var debug = require('debug')('gitlab');
 var urllib = require('urllib');
 var Milestone = require('./milestone');
 var Project = require('./project');
@@ -58,6 +59,7 @@ Client.prototype.request = function (method, pathname, data, callback) {
     dataType: 'json',
     data: data,
   }, function (err, result, res) {
+    debug('%s %s %j: result: %j, err: %j', method, url, data, result, err);
     if (err) {
       if (err.name === 'SyntaxError') {
         err.name = 'Gitlab' + res.statusCode + 'Error';

package.json

@@ -7,7 +7,8 @@
     "test": "make test"
   },
   "dependencies": {
-    "urllib": "0.3.4"
+    "urllib": "0.3.4",
+    "debug": "0.7.x"
   },
   "devDependencies": {
     "should": "*",

test/issue.test.js

@@ -22,7 +22,7 @@ describe('issue.test.js', function () {
         should.not.exists(err);
         row.id.should.equal(1098);
         row.should.have.keys('id', 'project_id', 'title', 'description', 'labels', 
-          'milestone', 'assignee', 'author', 'closed', 
+          'milestone', 'assignee', 'author', 'state',
           'updated_at', 'created_at');
         done();
       });
@@ -38,7 +38,7 @@ describe('issue.test.js', function () {
         issues.length.should.above(0);
         var row = issues[0];
         row.should.have.keys('id', 'project_id', 'title', 'description', 'labels', 
-          'milestone', 'assignee', 'author', 'closed', 
+          'milestone', 'assignee', 'author', 'state', 
           'updated_at', 'created_at');
         done();
       });
@@ -49,33 +49,49 @@ describe('issue.test.js', function () {
   describe('client.issues.create(), update()', function () {
     it('should create, update a issue', function (done) {
       client.issues.create({
-        id: 223, title: 'test title ' + new Date(), 
+        id: 223, 
+        title: 'test title ' + new Date(), 
         description: '测试 `markdown` \n [abc](/abc)',
-        assignee_id: 142, milestone_id: 117, labels: 'test,gitlabapi'
+        assignee_id: 142, 
+        milestone_id: 117, 
+        labels: 'test,gitlabapi'
       }, function (err, row) {
         should.not.exists(err);
         row.project_id.should.equal(223);
+        row.state.should.equal('opened');
         client.issues.update({
           id: 223,
           issue_id: row.id, 
-          closed: 1,
+          title: row.title + ' update',
+          state_event: 'close',
         }, function (err, row) {
           should.not.exists(err);
-          row.closed.should.equal(true);
+          row.title.should.include(' update');
+          row.state.should.equal('closed');
           done();
         });
       });
     });
 
-    it('should update a closed issue', function (done) {
+    it('should update a close, reopen and close issue', function (done) {
       client.issues.update({
         id: 223,
-        issue_id: 1098,
-        closed: 1
+        issue_id: 1385,
+        description: 'need to be closed!',
+        state_event: 'close',
       }, function (err, row) {
         should.not.exists(err);
-        row.closed.should.equal(true);
-        done();
+        row.state.should.equal('closed');
+        client.issues.update({
+          id: 223,
+          issue_id: 1385,
+          description: 'need to be reopen!',
+          state_event: 'reopen',
+        }, function (err, row) {
+          should.not.exists(err);
+          row.state.should.equal('reopened');
+          done();
+        });
       });
     });
 
@@ -87,7 +103,7 @@ describe('issue.test.js', function () {
         should.not.exists(err);
         rows.length.should.above(0);
         var row = rows[0];
-        row.should.have.keys('id', 'body', 'author', 'created_at');
+        row.should.have.keys('id', 'body', 'author', 'created_at', 'attachment');
         done();
       });
     });

test/member.test.js

@@ -20,7 +20,7 @@ describe('member.test.js', function () {
     it('should return a member', function (done) {
       client.members.get({id: 223, user_id: 142}, function (err, member) {
         should.not.exists(err);
-        member.should.have.keys('id', 'username', 'email', 'name', 'blocked', 'created_at', 'access_level');
+        member.should.have.keys('id', 'username', 'email', 'name', 'state', 'created_at', 'access_level');
         done();
       });
     });
@@ -34,7 +34,7 @@ describe('member.test.js', function () {
         should.not.exists(err);
         members.should.length(5);
         var member = members[0];
-        member.should.have.keys('id', 'username', 'email', 'name', 'blocked', 'created_at', 'access_level');
+        member.should.have.keys('id', 'username', 'email', 'name', 'state', 'created_at', 'access_level');
         done();
       });
     });

test/milestone.test.js

@@ -22,7 +22,7 @@ describe('milestone.test.js', function () {
         should.not.exists(err);
         milestone.should.have.property('id');
         milestone.should.have.keys('id', 'project_id', 'title', 'description',
-          'due_date', 'closed', 'updated_at', 'created_at');
+          'due_date', 'state', 'updated_at', 'created_at');
         done();
       });
     });
@@ -36,7 +36,7 @@ describe('milestone.test.js', function () {
         should.not.exists(err);
         milestones.should.length(5);
         milestones[0].should.have.keys('id', 'project_id', 'title', 'description',
-          'due_date', 'closed', 'updated_at', 'created_at');
+          'due_date', 'state', 'updated_at', 'created_at');
         done();
       });
     });
@@ -55,21 +55,21 @@ describe('milestone.test.js', function () {
         should.not.exists(err);
         milestone.should.have.property('id');
         milestone.should.have.property('project_id', 223);
-        milestone.closed.should.equal(false);
+        milestone.state.should.equal('active');
         milestone.due_date.should.equal('2013-02-14');
         client.milestones.update({
           id: 223, 
           milestone_id: milestone.id,
           title: milestone.title + ' || test update milestone' + new Date(),
           description: milestone.description + ' || \n ## description for update milestone' + new Date(),
           due_date: '2013-02-15',
-          closed: '1',
-          state: 'closed',
+          // closed: '1',
+          state_event: 'close',
         }, function (err, milestone) {
           should.not.exists(err);
           milestone.should.have.keys('id', 'project_id', 'title', 'description',
-            'due_date', 'closed', 'updated_at', 'created_at');
-          milestone.closed.should.equal(true);
+            'due_date', 'state', 'updated_at', 'created_at');
+          milestone.state.should.equal('closed');
           milestone.due_date.should.equal('2013-02-15');
           done();
         });

test/project.test.js

@@ -18,12 +18,14 @@ describe('project.test.js', function () {
   describe('client.projects.get()', function () {
 
     it('should return a project', function (done) {
-      client.projects.get({id: 223}, function (err, project) {
+      client.projects.get({id: 441}, function (err, project) {
         should.not.exists(err);
         project.should.have.keys('id', 'name', 'description', 'default_branch',
-          'owner', 'private', 'issues_enabled', 'merge_requests_enabled', 'wall_enabled',
+          'owner', 
+          'public', 'path', 'path_with_namespace', 'namespace',
+          'issues_enabled', 'merge_requests_enabled', 'wall_enabled',
           'wiki_enabled', 'created_at');
-        project.owner.should.have.keys('id', 'username', 'email', 'name', 'blocked', 'created_at');
+        project.owner.should.have.keys('id', 'username', 'email', 'name', 'state', 'created_at');
         done();
       });
     });
@@ -38,9 +40,11 @@ describe('project.test.js', function () {
         projects.should.length(5);
         var project = projects[0];
         project.should.have.keys('id', 'name', 'description', 'default_branch',
-          'owner', 'private', 'issues_enabled', 'merge_requests_enabled', 'wall_enabled',
+          'owner', 
+          'public', 'path', 'path_with_namespace', 'namespace',
+          'issues_enabled', 'merge_requests_enabled', 'wall_enabled',
           'wiki_enabled', 'created_at');
-        project.owner.should.have.keys('id', 'username', 'email', 'name', 'blocked', 'created_at');
+        project.owner.should.have.keys('id', 'username', 'email', 'name', 'state', 'created_at');
         done();
       });
     });
@@ -53,7 +57,9 @@ describe('project.test.js', function () {
         should.not.exists(err);
         project.should.have.keys('created_at', 'default_branch', 'description', 'id',
           'issues_enabled', 'merge_requests_enabled', 'name', 'namespace_id',
-          'owner_id', 'path', 'private_flag', 'updated_at', 'wall_enabled', 'wiki_enabled');
+          'creator_id', 'snippets_enabled', 'public',
+          'issues_tracker_id', 'issues_tracker',
+          'path', 'private_flag', 'updated_at', 'wall_enabled', 'wiki_enabled');
         done();
       });
     });