handling git@ and https:git@ urls

Author: bahmutov

index.js

@@ -6,7 +6,14 @@ module.exports = function (string) {
   var m = /^([\w-]+)\/([\w-.]+)((?:#|@).+)?$/.exec(string)
   if (m) return format(m)
 
-  if (!~string.indexOf('://')) return false
+  // normalize git@ and https:git@ urls
+  string = string.replace(/^git@/, 'https://')
+  string = string.replace(/^https:git@/, 'https://')
+  string = string.replace('.com:', '.com/')
+
+  if (!~string.indexOf('://')) {
+    return false
+  }
   var url = parse(string)
 
   switch (url.hostname) {

package.json

@@ -1,7 +1,7 @@
 {
   "name": "parse-github-repo-url",
   "description": "Parse a GitHub URL for user/project@version",
-  "version": "1.0.0",
+  "version": "1.1.0",
   "author": {
     "name": "Jonathan Ong",
     "email": "[email protected]",

test.js

@@ -37,3 +37,33 @@ describe('versioned', function () {
     })
   })
 })
+
+describe('url parse', function () {
+  var builtinUrlParse = require('url').parse
+
+  it('handles https:// url', function () {
+    var url = 'https://foo.com/bar'
+    var parsed = builtinUrlParse(url)
+    assert.equal('foo.com', parsed.hostname)
+  })
+
+  it('does not handle emails', function () {
+    var url = '[email protected]/bar'
+    var parsed = builtinUrlParse(url)
+    assert.equal(null, parsed.hostname, JSON.stringify(parsed))
+  })
+})
+
+describe('git @ syntax', function () {
+  it('works for git url', function () {
+    var url = '[email protected]:bahmutov/lazy-ass.git'
+    var parsed = parse(url)
+    assert.deepEqual(['bahmutov', 'lazy-ass', ''], parsed)
+  });
+
+  it('works for https:git url', function () {
+    var url = 'https:[email protected]:bahmutov/lazy-ass.git'
+    var parsed = parse(url)
+    assert.deepEqual(['bahmutov', 'lazy-ass', ''], parsed)
+  });
+})