Skip to content

Commit 1d097d0

Browse files
committed
Fix remove ALL logging
1 parent e7145a1 commit 1d097d0

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

robotframework_reportportal/listener.py

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@
4141

4242
DEFAULT_BINARY_FILE_TYPE = "application/octet-stream"
4343
TRUNCATION_SIGN = "...'"
44-
REMOVED_KEYWORD_LOG = "Keyword data removed using --removeKeywords option."
44+
REMOVED_KEYWORD_DATA_LOG = "Keyword data removed using --removeKeywords option."
45+
REMOVED_KEYWORD_CONTENT_LOG = "Content removed using the --remove-keywords option."
4546
REMOVED_WKUS_KEYWORD_LOG = "{number} failing items removed using the --remove-keywords option."
4647
REMOVED_FOR_WHILE_KEYWORD_LOG = "{number} passing items removed using the --remove-keywords option."
4748
WKUS_KEYWORD_NAME = "BuiltIn.Wait Until Keyword Succeeds"
@@ -129,7 +130,7 @@ class listener:
129130
_service: Optional[RobotService]
130131
_variables: Optional[Variables]
131132
_keyword_filters: List[_KeywordMatch] = []
132-
_remove_keyword_data: bool = False
133+
_remove_keyword_content: bool = False
133134
_remove_keywords: bool = False
134135
ROBOT_LISTENER_API_VERSION = 2
135136

@@ -314,7 +315,7 @@ def _process_keyword_skip(self):
314315
for pattern_str in set(current_context.output._settings.remove_keywords):
315316
pattern_str_upper = pattern_str.upper()
316317
if "ALL" == pattern_str_upper:
317-
self._remove_keyword_data = True
318+
self._remove_keyword_content = True
318319
break
319320
if "PASSED" == pattern_str_upper:
320321
self._remove_keywords = True
@@ -418,7 +419,7 @@ def _log_data_removed(self, item_id: str, timestamp: str, message: str) -> None:
418419
self.__post_log_message(msg)
419420

420421
def _log_keyword_data_removed(self, item_id: str, timestamp: str) -> None:
421-
self._log_data_removed(item_id, timestamp, REMOVED_KEYWORD_LOG)
422+
self._log_data_removed(item_id, timestamp, REMOVED_KEYWORD_DATA_LOG)
422423

423424
@check_rp_enabled
424425
def start_test(self, name: str, attributes: Dict, ts: Optional[Any] = None) -> None:
@@ -458,6 +459,9 @@ def end_test(self, _: Optional[str], attributes: Dict, ts: Optional[Any] = None)
458459
self._remove_current_item()
459460
self.service.finish_test(test=test, ts=ts)
460461

462+
def _log_keyword_content_removed(self, item_id: str, timestamp: str) -> None:
463+
self._log_data_removed(item_id, timestamp, REMOVED_KEYWORD_CONTENT_LOG)
464+
461465
def _do_start_keyword(self, keyword: Keyword, ts: Optional[str] = None) -> None:
462466
logger.debug(f"ReportPortal - Start Keyword: {keyword.robot_attributes}")
463467
keyword.rp_item_id = self.service.start_keyword(keyword=keyword, ts=ts)
@@ -475,7 +479,7 @@ def start_keyword(self, name: str, attributes: Dict, ts: Optional[Any] = None) -
475479
parent = self.current_item
476480
kwd.rp_parent_item_id = parent.rp_item_id
477481
skip_kwd = parent.remove_data
478-
kwd.remove_data = skip_kwd or self._remove_keyword_data
482+
kwd.remove_data = skip_kwd or self._remove_keyword_content
479483

480484
if kwd.remove_data:
481485
kwd.matched_filter = getattr(parent, "matched_filter", None)
@@ -494,6 +498,8 @@ def start_keyword(self, name: str, attributes: Dict, ts: Optional[Any] = None) -
494498
kwd.posted = False
495499
else:
496500
self._do_start_keyword(kwd, ts)
501+
if self._remove_keyword_content:
502+
self._log_keyword_content_removed(kwd.rp_item_id, kwd.start_time)
497503

498504
self._add_current_item(kwd)
499505

0 commit comments

Comments
 (0)