Add more tests

Author: HardNorth

examples/fixtures/test_failure_fixture_teardown/conftest.py

@@ -22,12 +22,12 @@
 LOGGER.setLevel(logging.DEBUG)
 logging.setLoggerClass(RPLogger)
 
-LOG_MESSAGE_BEFORE_YIELD = 'Log message before yield'
-LOG_MESSAGE_TEARDOWN = 'Log message for teardown'
+LOG_MESSAGE_BEFORE_YIELD = 'Log message before yield and test failure'
+LOG_MESSAGE_TEARDOWN = 'Log message for teardown after test failure'
 
 
 @pytest.fixture
-def fixture_teardown_config():
+def test_failure_fixture_teardown_config():
     logging.error(LOG_MESSAGE_BEFORE_YIELD)
     yield mock.Mock()
     logging.error(LOG_MESSAGE_TEARDOWN)

examples/fixtures/test_failure_fixture_teardown/test_fixture_teardown.py renamed to examples/fixtures/test_failure_fixture_teardown/test_failure_fixture_teardown.py

@@ -24,9 +24,5 @@
 #  See the License for the specific language governing permissions and
 #  limitations under the License.
 
-from time import sleep
-
-
-def test_failure_fixture_teardown(fixture_teardown_config):
-    sleep(0.001)
-    assert fixture_teardown_config is not None
+def test_failure_fixture_teardown(test_failure_fixture_teardown_config):
+    assert test_failure_fixture_teardown_config is None

tests/integration/test_fixtures.py

@@ -26,6 +26,9 @@
     LOG_MESSAGE_BEFORE_YIELD as LOG_MESSAGE_BEFORE_YIELD_FAILURE, LOG_MESSAGE_TEARDOWN as LOG_MESSAGE_TEARDOWN_FAILURE)
 from examples.fixtures.test_fixture_yield_none.conftest import LOG_MESSAGE_SETUP as LOG_MESSAGE_BEFORE_YIELD_NONE
 from examples.fixtures.test_fixture_return_none.conftest import LOG_MESSAGE_SETUP as LOG_MESSAGE_BEFORE_RETURN_NONE
+from examples.fixtures.test_failure_fixture_teardown.conftest import (
+    LOG_MESSAGE_BEFORE_YIELD as LOG_MESSAGE_BEFORE_YIELD_TEST_FAILURE,
+    LOG_MESSAGE_TEARDOWN as LOG_MESSAGE_TEARDOWN_TEST_FAILURE)
 from tests import REPORT_PORTAL_SERVICE
 from tests.helpers import utils
 
@@ -357,3 +360,62 @@ def test_fixture_return_none(mock_client_init):
     assert log_call_args[1] == LOG_MESSAGE_BEFORE_RETURN_NONE
     assert log_call_kwargs['item_id'] == f'{setup_step_name}_1'
 
+
+@mock.patch(REPORT_PORTAL_SERVICE)
+def test_failure_fixture_teardown(mock_client_init):
+    mock_client = mock_client_init.return_value
+    mock_client.step_reporter = StepReporter(mock_client)
+    set_current(mock_client)
+    mock_client.start_test_item.side_effect = generate_item_id
+    mock_client.finish_test_item.side_effect = remove_last_item_id
+    mock_client.current_item.side_effect = get_last_item_id
+
+    variables = dict(utils.DEFAULT_VARIABLES)
+    variables['rp_report_fixtures'] = True
+    result = utils.run_pytest_tests(tests=['examples/fixtures/test_failure_fixture_teardown'], variables=variables)
+    assert int(result) == 1, 'Exit code should be 1 (test failure)'
+
+    start_count = mock_client.start_test_item.call_count
+    finish_count = mock_client.finish_test_item.call_count
+    assert start_count == finish_count == 3, 'Incorrect number of "start_test_item" or "finish_test_item" calls'
+
+    call_args = mock_client.start_test_item.call_args_list
+    setup_call_args = call_args[1][0]
+    setup_step_name = 'function fixture setup: test_failure_fixture_teardown_config'
+    assert setup_call_args[0] == setup_step_name
+
+    setup_call_kwargs = call_args[1][1]
+    assert not setup_call_kwargs['has_stats']
+
+    teardown_call_args = call_args[-1][0]
+    teardown_step_name = 'function fixture teardown: test_failure_fixture_teardown_config'
+    assert teardown_call_args[0] == teardown_step_name
+
+    setup_call_kwargs = call_args[-1][1]
+    assert not setup_call_kwargs['has_stats']
+
+    log_count = mock_client.log.call_count
+    assert log_count == 3, 'Incorrect number of "log" calls'
+
+    log_call_args_list = mock_client.log.call_args_list
+    log_call_args = log_call_args_list[0][0]
+    log_call_kwargs = log_call_args_list[0][1]
+
+    assert log_call_args[1] == LOG_MESSAGE_BEFORE_YIELD_TEST_FAILURE
+    assert log_call_kwargs['item_id'] == f'{setup_step_name}_1'
+
+    log_call_args = log_call_args_list[2][0]
+    log_call_kwargs = log_call_args_list[2][1]
+
+    assert log_call_args[1] == LOG_MESSAGE_TEARDOWN_TEST_FAILURE
+    assert log_call_kwargs['item_id'] == \
+           ('examples/fixtures/test_failure_fixture_teardown/test_failure_fixture_teardown.py::'
+            'test_failure_fixture_teardown_1')
+
+    log_call_kwargs = log_call_args_list[1][1]
+
+    assert log_call_kwargs['message'].endswith(
+        'examples/fixtures/test_failure_fixture_teardown/test_failure_fixture_teardown.py:28: AssertionError')
+    assert log_call_kwargs['item_id'] == \
+           ('examples/fixtures/test_failure_fixture_teardown/test_failure_fixture_teardown.py::'
+            'test_failure_fixture_teardown_1')