Skip to content

Commit 36f3027

Browse files
committed
Fix Agent crash if Client could not be initialized
1 parent b00fe1a commit 36f3027

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
# Changelog
22

33
## [Unreleased]
4+
### Fixed
5+
- Agent crash if Client could not be initialized, by @HardNorth
46
### Changed
57
- Client version updated on [5.5.10](https://github.com/reportportal/client-Python/releases/tag/5.5.10), by @HardNorth
68

pytest_reportportal/service.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,8 @@ def issue_types(self) -> Dict[str, str]:
167167
project_settings = self.project_settings
168168
if not isinstance(self.project_settings, dict):
169169
project_settings = project_settings.blocking_result()
170+
if not project_settings:
171+
return self._issue_types
170172
for values in project_settings["subTypes"].values():
171173
for item in values:
172174
self._issue_types[item["shortName"]] = item["locator"]
@@ -864,6 +866,10 @@ def report_fixture(self, name: str, error_msg: str) -> None:
864866
:param name: Name of the fixture
865867
:param error_msg: Error message
866868
"""
869+
if not self.rp:
870+
yield
871+
return
872+
867873
reporter = self.rp.step_reporter
868874
item_id = reporter.start_nested_step(name, timestamp())
869875

@@ -874,6 +880,7 @@ def report_fixture(self, name: str, error_msg: str) -> None:
874880
if exception:
875881
if type(exception).__name__ != 'Skipped':
876882
status = 'FAILED'
883+
self.post_log(name, error_msg, log_level='ERROR')
877884
reporter.finish_nested_step(item_id, timestamp(), status)
878885
except Exception as e:
879886
LOGGER.error('Failed to report fixture: %s', name)

0 commit comments

Comments
 (0)