Fix for #304

Author: HardNorth

CHANGELOG.md

@@ -0,0 +1,10 @@
+# Changelog
+
+## [Unreleased]
+### Fixed
+- Issue [#304](https://github.com/reportportal/agent-python-pytest/issues/304):
+SSL certificate flag handling issue, by @HardNorth
+
+## [5.1.0]
+### Changed
+- Agent complete rewrite, by @HardNorth 

pytest_reportportal/config.py

@@ -1,5 +1,6 @@
 """This module contains class that stores RP agent configuration data."""
 
+from distutils.util import strtobool
 from os import getenv
 
 try:
@@ -64,7 +65,11 @@ def __init__(self, pytest_config):
                                            'true', '1', 'yes', 'y')
         self.rp_uuid = getenv('RP_UUID') or self.find_option(pytest_config,
                                                              'rp_uuid')
-        self.rp_verify_ssl = self.find_option(pytest_config, 'rp_verify_ssl')
+        rp_verify_ssl = self.find_option(pytest_config, 'rp_verify_ssl', True)
+        try:
+            self.rp_verify_ssl = bool(strtobool(rp_verify_ssl))
+        except (ValueError, AttributeError):
+            self.rp_verify_ssl = rp_verify_ssl
 
     # noinspection PyMethodMayBeStatic
     def find_option(self, pytest_config, option_name, default=None):
@@ -85,4 +90,6 @@ def find_option(self, pytest_config, option_name, default=None):
                 getattr(pytest_config.option, option_name, None) or
                 pytest_config.getini(option_name)
         )
+        if isinstance(value, bool):
+            return value
         return value if value else default

pytest_reportportal/config.pyi

@@ -1,5 +1,5 @@
 from _pytest.config import Config as Config
-from typing import List, Optional, Text, Union
+from typing import List, Optional, Text, Union, Any
 
 class AgentConfig:
     rp_rerun: Optional[bool] = ...
@@ -28,8 +28,9 @@ class AgentConfig:
     rp_retries: int = ...
     rp_skip_connection_test: bool = ...
     rp_uuid: Text = ...
-    rp_verify_ssl: bool = ...
+    rp_verify_ssl: Union[bool, Text] = ...
 
     def __init__(self, pytest_config: Config) -> None: ...
 
-    def find_option(self, pytest_config, param: Text) -> Union[Text, bool, list]: ...
+    def find_option(self, pytest_config, param: Text,
+                    default: Any = ...) -> Union[Text, bool, list]: ...

tests/unit/test_config.py

@@ -0,0 +1,36 @@
+#  Copyright (c) 2022 https://reportportal.io .
+#  Licensed under the Apache License, Version 2.0 (the "License");
+#  you may not use this file except in compliance with the License.
+#  You may obtain a copy of the License at
+#
+#  https://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License
+
+import pytest
+from pytest_reportportal.config import AgentConfig
+
+
+@pytest.mark.parametrize(
+    ['verify_ssl', 'expected_result'],
+    [
+        ('True', True),
+        ('False', False),
+        ('true', True),
+        ('false', False),
+        (True, True),
+        (False, False),
+        ('path/to/certificate', 'path/to/certificate'),
+        (None, True)
+    ]
+)
+def test_verify_ssl_true(mocked_config, verify_ssl, expected_result):
+    mocked_config.getini.side_effect = \
+        lambda x: verify_ssl if x == 'rp_verify_ssl' else None
+    config = AgentConfig(mocked_config)
+
+    assert config.rp_verify_ssl == expected_result