Merge pull request #119 from bigbZik/client-fix

Getting project settings if client support it

Author: Dzmitry Humianiuk

README.rst

@@ -77,7 +77,7 @@ The following parameters are optional:
 - :code:`rp_hierarchy_parametrize = True` - Enables hierarchy parametrized tests, default `False`. Doesn't support 'xdist' plugin.
 - :code:`rp_hierarchy_dirs_level = 0` - Directory starting hierarchy level (from pytest.ini level) (default `0`)
 - :code:`rp_issue_marks = 'xfail' 'issue'` - Pytest marks that could be used to get issue information (id, type, reason)
-- :code:`rp_issue_system_url = https://bugzilla.olympus.f5net.com/show_bug.cgi?id=` - URL to get issue description (issue id from pytest mark will be added to this URL)
+- :code:`rp_issue_system_url = http://bugzilla.some.com/show_bug.cgi?id={%issue_id}` - issue URL (issue_id will be filled by parameter from pytest mark)
 - :code:`rp_verify_ssl = True` - Verify SSL when connecting to the server
 - :code:`rp_display_suite_test_file = True` In case of True, include the suite's relative file path in the launch name as a convention of "<RELATIVE_FILE_PATH>::<SUITE_NAME>". In case of False, set the launch name to be the suite name only - this flag is relevant only when "rp_hierarchy_module" flag is set to False
 

pytest_reportportal/listener.py

@@ -1,6 +1,9 @@
-import cgi
 import pytest
 import logging
+try:
+    from html import escape   # python3
+except ImportError:
+    from cgi import escape    # python2
 
 
 try:
@@ -46,8 +49,7 @@ def pytest_runtest_makereport(self, item):
 
         if report.longrepr:
             self.PyTestService.post_log(
-                # Used for support python 2.7
-                cgi.escape(report.longreprtext),
+                escape(report.longreprtext),
                 loglevel='ERROR',
             )
 
@@ -101,17 +103,17 @@ def _add_issue_info(self, item, report):
                         issue_ids = [issue_ids]
                     comment += "\n" if comment else ""
                     comment += "Issues:"
-
                     for issue_id in issue_ids:
-                        comment += " [{}]({}{})".format(issue_id, url, issue_id) if url else " {}".format(issue_id)
+                        template = (" [{issue_id}]" + "({})".format(url)) if url else " {issue_id}"
+                        comment += template.format(issue_id=issue_id)
 
                 if "issue_type" in mark.kwargs:
                     issue_type = mark.kwargs["issue_type"]
 
-        if comment:
-            self.issue['comment'] = comment
-
-        if issue_type and self.PyTestService.issue_types and (issue_type in self.PyTestService.issue_types):
+        if issue_type and self.PyTestService.issue_types \
+                and (issue_type in self.PyTestService.issue_types):
+            if comment:
+                self.issue['comment'] = comment
             self.issue['issue_type'] = self.PyTestService.issue_types[issue_type]
             # self.issue['ignoreAnalyzer'] = True ???
         elif (report.when == 'setup') and report.skipped:

pytest_reportportal/service.py

@@ -94,7 +94,10 @@ def init_service(self, endpoint, project, uuid, log_batch_size,
                 log_batch_size=log_batch_size  # ,
                 # verify_ssl=verify_ssl
             )
-            self.project_settiings = None  # self.RP.rp_client.get_project_settings() if self.RP else None
+            if self.RP and hasattr(self.RP.rp_client, "get_project_settings"):
+                self.project_settiings = self.RP.rp_client.get_project_settings()
+            else:
+                self.project_settiings = None
             self.issue_types = self.get_issue_types()
         else:
             log.debug('The pytest is already initialized')