Skip to content

Commit d14fafb

Browse files
author
Ivan Ivanou
committed
Do not pass parameters as empty dictionary
1 parent bd8b85a commit d14fafb

File tree

3 files changed

+17
-2
lines changed

3 files changed

+17
-2
lines changed

pytest_reportportal/service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -475,7 +475,7 @@ def get_marker_value(item, keyword):
475475
return tags
476476

477477
def _get_parameters(self, item):
478-
return item.callspec.params if hasattr(item, 'callspec') else {}
478+
return item.callspec.params if hasattr(item, 'callspec') else None
479479

480480
@staticmethod
481481
def _get_item_name(test_item):

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ def read_file(fname):
88
return f.read()
99

1010

11-
version = '5.0.1'
11+
version = '5.0.2'
1212

1313

1414
requirements = [

tests/test_service.py

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
from six.moves import mock
44

5+
from delayed_assert import expect, assert_expectations
56
import pytest
67

78

@@ -28,3 +29,17 @@ def __iter__(self):
2829
test_item.get_closest_marker = get_closest_marker
2930
markers = rp_service._get_item_markers(test_item)
3031
assert markers == [{'value': 'test_marker'}, {'value': 'ini_marker'}]
32+
33+
34+
def test_get_item_parameters(rp_service):
35+
"""Test that parameters are returned in a way supported by the client."""
36+
test_item = mock.Mock()
37+
test_item.callspec.params = {'param': 'param_value'}
38+
39+
expect(rp_service._get_parameters(test_item) == {'param': 'param_value'})
40+
41+
delattr(test_item, 'callspec')
42+
expect(rp_service._get_parameters(test_item) is None)
43+
44+
assert_expectations()
45+

0 commit comments

Comments
 (0)