Skip to content

Commit f1d9f63

Browse files
author
Roman Plevka
authored
Fix --rp-launch-id parsing
1 parent d7660b9 commit f1d9f63

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

pytest_reportportal/plugin.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ def pytest_sessionstart(session):
7777
uuid=getenv('RP_UUID') or session.config.getini('rp_uuid'),
7878
log_batch_size=int(session.config.getini('rp_log_batch_size')),
7979
ignore_errors=bool(session.config.getini('rp_ignore_errors')),
80-
custom_launch=session.config.getini('rp_launch_id') or None,
80+
custom_launch=session.config.option.rp_launch_id or None,
8181
ignored_attributes=session.config.getini(
8282
'rp_ignore_attributes'),
8383
verify_ssl=session.config.getini('rp_verify_ssl'),
@@ -92,7 +92,7 @@ def pytest_sessionstart(session):
9292

9393
attributes = gen_attributes(
9494
session.config.getini('rp_launch_attributes'))
95-
if not session.config.getini('rp_launch_id'):
95+
if not session.config.option.rp_launch_id:
9696
session.config.py_test_service.start_launch(
9797
session.config.option.rp_launch,
9898
attributes=attributes,
@@ -142,7 +142,7 @@ def pytest_sessionfinish(session):
142142
return
143143

144144
if is_master(session.config):
145-
if not session.config.getini('rp_launch_id'):
145+
if not session.config.option.rp_launch_id:
146146
session.config.py_test_service.finish_launch()
147147

148148

@@ -188,6 +188,8 @@ def pytest_configure(config):
188188
if not config.option.rp_launch_description:
189189
config.option.rp_launch_description = config.\
190190
getini('rp_launch_description')
191+
if not config.option.rp_launch_id:
192+
config.option.rp_launch_id = config.getini('rp_launch_id')
191193

192194
if is_master(config):
193195
config.py_test_service = PyTestServiceClass()

tests/test_plugin.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ def test_portal_on_maintenance(mocked_session):
8383
8484
:param mocked_session: pytest fixture
8585
"""
86+
mocked_session.config.option = mock.Mock()
8687
mocked_session.config.py_test_service = mock.Mock()
8788
mocked_session.config.py_test_service.init_service.side_effect = \
8889
ResponseError("<title>Report Portal - Maintenance</title>")

0 commit comments

Comments
 (0)