Skip to content

Commit 038602b

Browse files
committed
Removed redundant logic. Updated QueueListener timeout param with safer version
1 parent f9c2626 commit 038602b

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

reportportal_client/service_async.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -28,17 +28,17 @@
2828
class QueueListener(object):
2929
_sentinel_item = None
3030

31-
def __init__(self, queue, queue_get_timeout, *handlers):
31+
def __init__(self, queue, *handlers, **kwargs):
3232
self.queue = queue
33-
self.queue_get_timeout = queue_get_timeout
33+
self.queue_get_timeout = kwargs.get("queue_get_timeout", None)
3434
self.handlers = handlers
3535
self._stop_nowait = threading.Event()
3636
self._stop = threading.Event()
3737
self._thread = None
3838

39-
def dequeue(self, block=True, timeout=None):
39+
def dequeue(self, block=True):
4040
"""Dequeue a record and return item."""
41-
return self.queue.get(block, timeout)
41+
return self.queue.get(block, self.queue_get_timeout)
4242

4343
def start(self):
4444
"""Start the listener.
@@ -83,7 +83,7 @@ def _monitor(self):
8383
has_task_done = hasattr(q, 'task_done')
8484
while not self._stop.isSet():
8585
try:
86-
record = self.dequeue(True, self.queue_get_timeout)
86+
record = self.dequeue(True)
8787
if record is self._sentinel_item:
8888
break
8989
self.handle(record)
@@ -161,8 +161,8 @@ def __init__(self, endpoint, project, token, api_base="api/v1",
161161
"start_test_item", "finish_test_item", "log"]
162162

163163
self.queue = queue.Queue()
164-
self.listener = QueueListener(self.queue, queue_get_timeout,
165-
self.process_item)
164+
self.listener = QueueListener(self.queue, self.process_item,
165+
queue_get_timeout=queue_get_timeout)
166166
self.listener.start()
167167
self.lock = threading.Lock()
168168

0 commit comments

Comments
 (0)