Skip to content

Commit 1ab48e7

Browse files
committed
Test fixes
1 parent f4daea8 commit 1ab48e7

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

reportportal_client/steps/__init__.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,13 @@ def __enter__(self):
8585
self.__item_id = rp_client.step_reporter \
8686
.start_nested_step(self.name, timestamp(), parameters=self.params)
8787
if self.params:
88-
rp_client.log(timestamp(), "Parameters: " + str(self.params),
89-
level='INFO', item_id=self.__item_id)
88+
param_list = [
89+
str(key) + ": " + str(value)
90+
for key, value in sorted(self.params.items())
91+
]
92+
param_str = 'Parameters: ' + '; '.join(param_list)
93+
rp_client.log(timestamp(), param_str, level='INFO',
94+
item_id=self.__item_id)
9095

9196
def __exit__(self, exc_type, exc_val, exc_tb):
9297
# Cannot call _local.current() early since it will be initialized
@@ -112,6 +117,7 @@ def wrapper(*args, **kwargs):
112117
params = get_function_params(func, args, kwargs)
113118
with Step(self.name, params, self.status, self.client):
114119
return func(*args, **kwargs)
120+
115121
return wrapper
116122

117123

tests/steps/test_steps.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,23 +123,23 @@ def test_verify_parameters_logging_default_value(rp_client):
123123
nested_step_params(1, 'two')
124124
assert len(rp_client._log_manager._logs_batch) == 1
125125
assert rp_client._log_manager._logs_batch[0].message \
126-
== "Parameters: {'param1': 1, 'param2': 'two'}"
126+
== "Parameters: param1: 1; param2: two"
127127

128128

129129
def test_verify_parameters_logging_no_default_value(rp_client):
130130
rp_client.step_reporter.set_parent('STEP', PARENT_STEP_ID)
131131
nested_step_params(1, 'two', 'three')
132132
assert len(rp_client._log_manager._logs_batch) == 1
133133
assert rp_client._log_manager._logs_batch[0].message \
134-
== "Parameters: {'param1': 1, 'param2': 'two', 'param3': 'three'}"
134+
== "Parameters: param1: 1; param2: two; param3: three"
135135

136136

137137
def test_verify_parameters_logging_named_value(rp_client):
138138
rp_client.step_reporter.set_parent('STEP', PARENT_STEP_ID)
139139
nested_step_params(1, 'two', param3='three')
140140
assert len(rp_client._log_manager._logs_batch) == 1
141141
assert rp_client._log_manager._logs_batch[0].message \
142-
== "Parameters: {'param1': 1, 'param2': 'two', 'param3': 'three'}"
142+
== "Parameters: param1: 1; param2: two; param3: three"
143143

144144

145145
def test_verify_parameters_inline_logging(rp_client):
@@ -148,4 +148,4 @@ def test_verify_parameters_inline_logging(rp_client):
148148
pass
149149
assert len(rp_client._log_manager._logs_batch) == 1
150150
assert rp_client._log_manager._logs_batch[0].message \
151-
== "Parameters: {'param1': 1, 'param2': 'two'}"
151+
== "Parameters: param1: 1; param2: two"

0 commit comments

Comments
 (0)