Skip to content

Commit 4ad1d3e

Browse files
authored
Merge pull request #201 from ericscobell/develop
Allow setting `HTTPAdapter.pool_maxsize` without `retries`
2 parents da33ed5 + fdd1e20 commit 4ad1d3e

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

reportportal_client/client.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
import logging
1717
import requests
18-
from requests.adapters import HTTPAdapter, Retry
18+
from requests.adapters import HTTPAdapter, Retry, DEFAULT_RETRIES
1919

2020
from ._local import set_current
2121
from .core.rp_requests import (
@@ -100,16 +100,16 @@ def __init__(self,
100100
self.step_reporter = StepReporter(self)
101101
self._item_stack = []
102102
self.mode = mode
103-
if retries:
104-
retry_strategy = Retry(
105-
total=retries,
106-
backoff_factor=0.1,
107-
status_forcelist=[429, 500, 502, 503, 504]
108-
)
109-
self.session.mount('https://', HTTPAdapter(
110-
max_retries=retry_strategy, pool_maxsize=max_pool_size))
111-
self.session.mount('http://', HTTPAdapter(
112-
max_retries=retry_strategy, pool_maxsize=max_pool_size))
103+
104+
retry_strategy = Retry(
105+
total=retries,
106+
backoff_factor=0.1,
107+
status_forcelist=[429, 500, 502, 503, 504]
108+
) if retries else DEFAULT_RETRIES
109+
self.session.mount('https://', HTTPAdapter(
110+
max_retries=retry_strategy, pool_maxsize=max_pool_size))
111+
self.session.mount('http://', HTTPAdapter(
112+
max_retries=retry_strategy, pool_maxsize=max_pool_size))
113113
self.session.headers['Authorization'] = 'bearer {0}'.format(self.token)
114114

115115
self._log_manager = LogManager(

reportportal_client/service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -590,4 +590,4 @@ def _log_batch(self, log_data, force=False):
590590
"Report Portal Batch Log request failed after %d attempts",
591591
POST_LOGBATCH_RETRY_COUNT,
592592
exc_info=exceptions[-1]
593-
)
593+
)

0 commit comments

Comments
 (0)