Skip to content

Commit 77ff26e

Browse files
authored
Merge pull request #158 from reportportal/interpreter-report-updated2
Add interpreter to GA
2 parents 8d41543 + ad3d56a commit 77ff26e

File tree

3 files changed

+18
-6
lines changed

3 files changed

+18
-6
lines changed

reportportal_client/external/google_analytics.py

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
"""
1717

1818
import logging
19+
from platform import python_version
1920
from pkg_resources import get_distribution
2021
import requests
2122
from uuid import uuid4
@@ -34,6 +35,14 @@ def _get_client_info():
3435
return client.project_name, client.version
3536

3637

38+
def _get_platform_info():
39+
"""Get current platform basic info, e.g.: 'Python 3.6.1'.
40+
41+
:return: str represents the current platform, e.g.: 'Python 3.6.1'
42+
"""
43+
return 'Python ' + python_version()
44+
45+
3746
def send_event(agent_name, agent_version):
3847
"""Send an event to GA about client and agent versions with their names.
3948
@@ -47,8 +56,8 @@ def send_event(agent_name, agent_version):
4756
'aip': '1',
4857
'cid': str(uuid4()),
4958
't': 'event',
50-
'ec': 'Client name "{}", version "{}"'.format(
51-
client_name, client_version
59+
'ec': 'Client name "{}", version "{}", interpreter "{}"'.format(
60+
client_name, client_version, _get_platform_info()
5261
),
5362
'ea': 'Start launch',
5463
'el': 'Agent name "{}", version "{}"'.format(

reportportal_client/external/google_analytics.pyi

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,6 @@ logger: Logger
77

88
def _get_client_info() -> tuple: ...
99

10+
def _get_platform_info() -> Text: ...
11+
1012
def send_event(agent_name: Text, agent_version: Text) -> requests.Response: ...

tests/test_analytics.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@
2727
mock.Mock(return_value=555))
2828
@mock.patch('reportportal_client.external.google_analytics.requests.post')
2929
@mock.patch('reportportal_client.external.google_analytics.get_distribution')
30+
@mock.patch('reportportal_client.external.google_analytics.python_version',
31+
mock.Mock(return_value='3.6.6'))
3032
def test_send_event(mocked_distribution, mocked_requests):
3133
"""Test functionality of the send_event() function.
3234
@@ -46,13 +48,12 @@ def test_send_event(mocked_distribution, mocked_requests):
4648
'aip': '1',
4749
'cid': '555',
4850
't': 'event',
49-
'ec': 'Client name "{}", version "{}"'.format(
50-
expected_cl_name, expected_cl_version
51-
),
51+
'ec': 'Client name "{}", version "{}", interpreter "Python 3.6.6"'
52+
.format(expected_cl_name, expected_cl_version),
5253
'ea': 'Start launch',
5354
'el': 'Agent name "{}", version "{}"'.format(
5455
agent_name, agent_version
55-
)
56+
)
5657
}
5758
send_event(agent_name, agent_version)
5859
mocked_requests.assert_called_with(

0 commit comments

Comments
 (0)