Fix for #180

Author: HardNorth

CHANGELOG.md

@@ -0,0 +1,10 @@
+# Changelog
+
+## [Unreleased]
+### Fixed
+- Issue [#180](https://github.com/reportportal/client-Python/issues/180):
+logger crash on attachments, by @HardNorth
+
+## [5.2.0]
+### Changed
+- Client fixes, by @HardNorth

reportportal_client/core/rp_file.py

@@ -1,5 +1,7 @@
 """This module contains classes representing RP file object."""
 
+import uuid
+
 
 class RPFile(object):
     """Class representation for a file that will be attached to the log."""
@@ -20,7 +22,7 @@ def __init__(self,
         """
         self.content = content or data
         self.content_type = content_type or mime
-        self.name = name
+        self.name = name if name and name.strip() else str(uuid.uuid4())
 
     @property
     def payload(self):

reportportal_client/core/rp_requests.py

@@ -440,7 +440,7 @@ def __init__(self, log_reqs):
 
     def __get_file(self, rp_file):
         """Form a tuple for the single file."""
-        return ('file', (rp_file.name or uuid.uuid4(),
+        return ('file', (rp_file.name,
                          rp_file.content,
                          rp_file.content_type or self.default_content))
 

tests/logs/test_rp_file.py

@@ -0,0 +1,33 @@
+#  Copyright (c) 2022 https://reportportal.io .
+#  Licensed under the Apache License, Version 2.0 (the "License");
+#  you may not use this file except in compliance with the License.
+#  You may obtain a copy of the License at
+#
+#  https://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License
+
+import pytest
+
+from core.rp_file import RPFile
+
+
+@pytest.mark.parametrize(
+    ['name'],
+    [
+        [''],
+        [None],
+        ['   ']
+    ]
+)
+def test_rp_file_name_should_not_be_empty(name):
+    file = RPFile(name, '{"test": true}', 'application/json')
+
+    payload = file.payload
+    assert payload['name']
+    assert len(payload['name']) > 10
+