Skip to content

Commit eeafd77

Browse files
committed
Review fixes
1 parent 0e714e7 commit eeafd77

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

reportportal_client/external/google_analytics.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ def _get_platform_info():
4040
4141
:return: str represents the current platform, e.g.: 'Python 3.6.1'
4242
"""
43-
return "Python " + python_version()
43+
return 'Python ' + python_version()
4444

4545

4646
def send_event(agent_name, agent_version):

reportportal_client/external/google_analytics.pyi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@ logger: Logger
77

88
def _get_client_info() -> tuple: ...
99

10-
def _get_platform_info() -> str: ...
10+
def _get_platform_info() -> Text: ...
1111

1212
def send_event(agent_name: Text, agent_version: Text) -> requests.Response: ...

tests/test_analytics.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
@mock.patch('reportportal_client.external.google_analytics.requests.post')
3131
@mock.patch('reportportal_client.external.google_analytics.get_distribution')
3232
@mock.patch('reportportal_client.external.google_analytics.python_version',
33-
mock.Mock(return_value=TEST_PYTHON_VERSION))
33+
mock.Mock(return_value='3.6.6'))
3434
def test_send_event(mocked_distribution, mocked_requests):
3535
"""Test functionality of the send_event() function.
3636
@@ -50,9 +50,8 @@ def test_send_event(mocked_distribution, mocked_requests):
5050
'aip': '1',
5151
'cid': '555',
5252
't': 'event',
53-
'ec': 'Client name "{}", version "{}", interpreter "Python {}"'.format(
54-
expected_cl_name, expected_cl_version, TEST_PYTHON_VERSION
55-
),
53+
'ec': 'Client name "{}", version "{}", interpreter "Python 3.6.6"'
54+
.format(expected_cl_name, expected_cl_version),
5655
'ea': 'Start launch',
5756
'el': 'Agent name "{}", version "{}"'.format(
5857
agent_name, agent_version

0 commit comments

Comments
 (0)