improve error message for part 1 issue #10

Author: krasoffski

reportportal_client/errors.py

@@ -0,0 +1,16 @@
+class Error(Exception):
+    """General exception for package."""
+
+
+class EntryCreatedError(Error):
+    """Represents error in case no entry is created.
+
+    No 'id' in the json response.
+    """
+
+
+class OperationCompletionError(Error):
+    """Represents error in case of operation failure.
+
+    No 'msg' in the json response.
+    """

reportportal_client/model/response.py

@@ -1,12 +1,15 @@
 import json
 
+from ..errors import EntryCreatedError, OperationCompletionError
+
 
 class RS(object):
     def __init__(self, raw):
         super(RS, self).__init__()
         self.raw = raw
 
 
+# FIXME: need to improve and rework errors handling, add checks of err codes
 class EntryCreatedRS(RS):
     def __init__(self, raw):
         super(EntryCreatedRS, self).__init__(raw)
@@ -15,14 +18,14 @@ def __init__(self, raw):
     def id(self):
         try:
             return json.loads(self.raw)["id"]
-        except KeyError as error:
-            error.message += "Raw: {0}".format(self.raw)
-            raise
+        except KeyError:
+            raise EntryCreatedError("raw: {0}".format(self.raw))
 
     def as_dict(self):
         return {"id": self.id}
 
 
+# FIXME: need to improve and rework errors handling, add checks of err codes
 class OperationCompletionRS(RS):
     def __init__(self, raw):
         super(OperationCompletionRS, self).__init__(raw)
@@ -31,9 +34,8 @@ def __init__(self, raw):
     def msg(self):
         try:
             return json.loads(self.raw)["msg"]
-        except KeyError as error:
-            error.message += "Raw: {0}".format(self.raw)
-            raise
+        except KeyError:
+            raise OperationCompletionError("raw: {0}".format(self.raw))
 
     def as_dict(self):
         return {"msg": self.msg}