Fix .NET 4.6.2 Discovery (#62)

* fix net462 discovery

* Update CHANGELOG

Author: gasparnagy

CHANGELOG.md

@@ -9,6 +9,7 @@
 
 * Fix: Error message box when creating feature file with space in its name (#50)
 * Fix: Error during discovery of .NET 4 projects when .NET 6.0 is not installed (#53)
+* Fix: Bindings cannot be discovered for .NET 4.6.2 projects (#62)
 
 *Contributors of this release (in alphabetical order):* @gasparnagy, @RikvanSpreuwel
 

Connectors/Reqnroll.VisualStudio.ReqnrollConnector.Generic/AssemblyLoading/RuntimeCompositeCompilationAssemblyResolver.cs

@@ -11,15 +11,22 @@ public RuntimeCompositeCompilationAssemblyResolver(ICompilationAssemblyResolver[
         _log = log;
     }
 
-    public bool TryResolveAssemblyPaths(CompilationLibrary library, List<string> assemblies)
+    public bool TryResolveAssemblyPaths(CompilationLibrary library, List<string>? assemblies)
     {
         foreach (ICompilationAssemblyResolver resolver in _resolvers)
             try
             {
                 if (resolver.TryResolveAssemblyPaths(library, assemblies) &&
+                    assemblies != null &&
                     assemblies.Any(a => !IsRefsPath(a)))
                 {
-                    var resolveAssemblyPath = assemblies.FirstOrDefault(a => !IsRefsPath(a));
+                    var resolveAssemblyPath = assemblies.First(a => !IsRefsPath(a));
+                    if ("System.Runtime.dll".Equals(Path.GetFileName(resolveAssemblyPath), StringComparison.OrdinalIgnoreCase))
+                    {
+                        _log.Info($"Skipping {resolveAssemblyPath} ({resolver})");
+                        assemblies.Remove(resolveAssemblyPath);
+                        return false;
+                    }
                     _log.Info($"Resolved with {resolver} from {resolveAssemblyPath}");
                     return true;
                 }

Connectors/SpecFlow.VisualStudio.SpecFlowConnector.Generic/AssemblyLoading/RuntimeCompositeCompilationAssemblyResolver.cs

@@ -11,15 +11,22 @@ public RuntimeCompositeCompilationAssemblyResolver(ICompilationAssemblyResolver[
         _log = log;
     }
 
-    public bool TryResolveAssemblyPaths(CompilationLibrary library, List<string> assemblies)
+    public bool TryResolveAssemblyPaths(CompilationLibrary library, List<string>? assemblies)
     {
         foreach (ICompilationAssemblyResolver resolver in _resolvers)
             try
             {
                 if (resolver.TryResolveAssemblyPaths(library, assemblies) &&
+                    assemblies != null &&
                     assemblies.Any(a => !IsRefsPath(a)))
                 {
-                    var resolveAssemblyPath = assemblies.FirstOrDefault(a => !IsRefsPath(a));
+                    var resolveAssemblyPath = assemblies.First(a => !IsRefsPath(a));
+                    if ("System.Runtime.dll".Equals(Path.GetFileName(resolveAssemblyPath), StringComparison.OrdinalIgnoreCase))
+                    {
+                        _log.Info($"Skipping {resolveAssemblyPath} ({resolver})");
+                        assemblies.Remove(resolveAssemblyPath);
+                        return false;
+                    }
                     _log.Info($"Resolved with {resolver} from {resolveAssemblyPath}");
                     return true;
                 }