Reqnroll
Include BoDi to Reqnroll repo #40
-
|
BoDi, the simple IoC container used in Reqnroll, is still in the SpecFlowOSS organization afaict. Should this be moved to the Reqnroll organization as well? |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 4 replies
-
|
It's soo good to see that you are faster processing my TODO list than myself. The short answer is: yes. My suggestion would be to include it to the main Reqnroll repo tough. (We can still make a separate NuGet package of that as Reqnroll.BoDi.) Having it in the same repo makes development and debugging (especially paraellel isssues) much easier. I would put it in a root folder "Reqnroll.BoDi" (like "Reqnroll.Utils") and include it's unit tests to the Tests/Reqnroll.RuntimeTests (maybe in a BoDi subfolder). I would not worry about the history in this case - it is a simple code - just make a code drop as it is right now. |
Beta Was this translation helpful? Give feedback.
-
|
Ok, I'm having a go at this (I need BoDi to port my plugin anyway). Adding the BoDi project was pretty easy, adding the tests (which are still NUnit based and use something different to FluentAssertions) is a little bit more complicated. Doing the work here. |
Beta Was this translation helpful? Give feedback.
-
|
@mbhoek perfect, thx. I have added you as to the main repo, so next time you can do it in a simple branch as well. |
Beta Was this translation helpful? Give feedback.
-
|
@gasparnagy Just to be clear; you are allowing me to branch straight off |
Beta Was this translation helpful? Give feedback.
-
|
@mbhoek yes, exactly. I guess it is easier that way and for more complex PR it is easier to collaborate with others that way. |
Beta Was this translation helpful? Give feedback.
-
|
The related PR #80 is done & merged. Thx @mbhoek. Closing this discussion. |
Beta Was this translation helpful? Give feedback.
It's soo good to see that you are faster processing my TODO list than myself.
The short answer is: yes.
My suggestion would be to include it to the main Reqnroll repo tough. (We can still make a separate NuGet package of that as Reqnroll.BoDi.) Having it in the same repo makes development and debugging (especially paraellel isssues) much easier. I would put it in a root folder "Reqnroll.BoDi" (like "Reqnroll.Utils") and include it's unit tests to the Tests/Reqnroll.RuntimeTests (maybe in a BoDi subfolder). I would not worry about the history in this case - it is a simple code - just make a code drop as it is right now.