Skip to content

Commit 92c1c2f

Browse files
authored
chore: update release pipeline to make it work for linux (#111)
1 parent c57b49a commit 92c1c2f

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

.github/workflows/release_desktop_app.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
- name: Install Node.js, NPM and Yarn
3737
uses: actions/setup-node@v2
3838
with:
39-
node-version: 16.15
39+
node-version: 20.9.0
4040

4141
- name: Install desktop app dependencies
4242
run: bash ./install.sh
@@ -57,4 +57,4 @@ jobs:
5757

5858
# If the commit is tagged with a version (e.g. "v1.0.0"),
5959
# release the app after building
60-
release: false
60+
release: true

src/main/actions/makeApiClientRequest.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ const makeApiClientRequest = async ({ apiRequest }) => {
4040
data: body,
4141
responseType: "arraybuffer",
4242
withCredentials: false,
43-
validateStatus: (status) => {
43+
validateStatus: () => {
4444
return true;
4545
},
4646
});
@@ -75,6 +75,7 @@ const makeApiClientRequest = async ({ apiRequest }) => {
7575
redirectedUrl: responseURL !== url ? responseURL : "",
7676
};
7777
} catch (e) {
78+
console.log("Error while making api client request", e);
7879
return null;
7980
}
8081
};

src/renderer/actions/apps/os/ca/windows.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const { exec, execSync } = require("child_process");
1+
const { execSync } = require("child_process");
22

33
const installWindowsCert = async (certPath) => {
44
const command = `certutil -user -addstore Root ${certPath}`;
@@ -12,8 +12,7 @@ const installWindowsCert = async (certPath) => {
1212
}
1313
};
1414

15-
const deleteWindowsCert = async(caName) => {
16-
console.log("Deleting Windows Cert")
15+
const deleteWindowsCert = async (caName) => {
1716
const command = `certutil -delstore -user Root ${caName}`;
1817
try {
1918
execSync(command);
@@ -23,6 +22,6 @@ const deleteWindowsCert = async(caName) => {
2322
console.log(err);
2423
return false;
2524
}
26-
}
25+
};
2726

2827
export { installWindowsCert, deleteWindowsCert };

0 commit comments

Comments
 (0)