fix: serve without hitting server for modfy graphql response (#64)

Author: nsrCodes

src/components/proxy-middleware/index.js

@@ -157,11 +157,15 @@ class ProxyMiddlewareManager {
               headers: responseHeaders,
               body: ctx.rq_response_body,
             });
-          logger_middleware.send_network_log(
+          if(!ctx.rq.request_finished) {
+            logger_middleware.send_network_log(
               ctx,
               rules_middleware.action_result_objs,
               GLOBAL_CONSTANTS.REQUEST_STATE.COMPLETE
             )
+          } else {
+            console.log("Expected Error after early termination of request: ", err);
+          }
         }
 
         return callback();
@@ -188,8 +192,15 @@ class ProxyMiddlewareManager {
 
         if (parsedBody && RQ_INTERCEPTED_CONTENT_TYPES.includes(contentType)) {
           // Do modifications, if any
-          const { action_result_objs, continue_request } =
-            await rules_middleware.on_request_end(ctx);
+          const { action_result_objs, continue_request } = await rules_middleware.on_request_end(ctx);
+          if(!continue_request) {
+            logger_middleware.send_network_log(
+              ctx,
+              rules_middleware.action_result_objs,
+              GLOBAL_CONSTANTS.REQUEST_STATE.COMPLETE
+            );
+            return;
+          }
         }
 
         // Use the updated request

src/components/proxy-middleware/middlewares/rules_middleware.js

@@ -129,6 +129,8 @@ class RulesMiddleware {
     }
     this._update_request_data({ request_body: ctx.rq.get_json_request_body() });
 
+    this.on_request_actions = this._process_rules();
+
     const { action_result_objs, continue_request } =
       await this.rule_action_processor.process_actions(
         this.on_request_actions,

src/components/proxy-middleware/rule_action_processor/index.js

@@ -47,7 +47,9 @@ class RuleActionProcessor {
       if(typeof(body) !== 'string') {
         body = JSON.stringify(body);
       }
+
       ctx.proxyToClientResponse.writeHead(status_code, headers).end(body);
+      ctx.rq.request_finished = true;
 
       ctx.rq.set_final_response({
         status_code: status_code,

src/components/proxy-middleware/rule_action_processor/processors/modify_response_processor.js

@@ -10,13 +10,21 @@ import { executeUserFunction, getFunctionFromString } from "../../../../utils";
 import { RQ_INTERCEPTED_CONTENT_TYPES } from "../../constants";
 
 const process_modify_response_action = async (action, ctx) => {
-  const allowed_handlers = [PROXY_HANDLER_TYPE.ON_REQUEST,PROXY_HANDLER_TYPE.ON_RESPONSE_END, PROXY_HANDLER_TYPE.ON_ERROR];
+  const allowed_handlers = [
+    PROXY_HANDLER_TYPE.ON_REQUEST,
+    PROXY_HANDLER_TYPE.ON_REQUEST_END,
+    PROXY_HANDLER_TYPE.ON_RESPONSE_END, 
+    PROXY_HANDLER_TYPE.ON_ERROR
+  ];
 
   if (!allowed_handlers.includes(ctx.currentHandler)) {
     return build_action_processor_response(action, false);
   }
 
-  if(ctx.currentHandler === PROXY_HANDLER_TYPE.ON_REQUEST) {
+  if(
+    ctx.currentHandler === PROXY_HANDLER_TYPE.ON_REQUEST ||
+    ctx.currentHandler === PROXY_HANDLER_TYPE.ON_REQUEST_END
+  ) {
     if(action.serveWithoutRequest) {
       let contentType, finalBody;
       if(action.responseType === GLOBAL_CONSTANTS.RESPONSE_BODY_TYPES.LOCAL_FILE) {
@@ -44,7 +52,13 @@ const process_modify_response_action = async (action, ctx) => {
 
       const status = action.statusCode || 200
 
-      const finalHeaders = {"Content-Type": contentType}
+      const finalHeaders = {
+        "content-type": contentType,
+        "access-control-allow-origin": "*",
+        "access-control-allow-methods": "*",
+        "access-control-allow-headers": "*",
+        "access-control-allow-credentials": "true",
+      }
       modify_response(ctx, finalBody, status)
       return build_action_processor_response(
         action,