532: moves the logger warning to the requests initializer, updates tests

Author: Jacques Troussard

requests_oauthlib/__init__.py

@@ -21,3 +21,10 @@
 
 logging.getLogger("requests_oauthlib").addHandler(logging.NullHandler())
 logging.getLogger("requests_oauthlib").addFilter(DebugModeTokenFilter())
+
+for filter_ in logging.getLogger("requests_oauthlib").filters:
+    if isinstance(filter_, DebugModeTokenFilter):
+        if filter_.mode == 'DEFAULT':
+            msg = "Your logger, when in DEBUG mode, will log TOKENS"
+            logging.warning(msg)
+        break 

requests_oauthlib/log_filters.py

@@ -20,7 +20,7 @@ def __init__(self):
         environment variable.
         """
         super().__init__()
-        self.mode = os.getenv('DEBUG_MODE_TOKEN_FILTER', 'DEFAULT').upper() 
+        self.mode = os.getenv('DEBUG_MODE_TOKEN_FILTER', 'DEFAULT').upper()
 
     def filter(self, record):
         """
@@ -37,7 +37,4 @@ def filter(self, record):
                 record.msg = re.sub(r'Bearer (\w+)', '[MASKED]', record.getMessage())
             elif self.mode == "SUPPRESS":
                 return False
-            elif self.mode == "DEFAULT":
-                msg = "Your logger, when in DEBUG mode, will log TOKENS"
-                raise Warning(msg)
-            return True
+            return True # if mode is not MASKED then DEFAULT is implied 

tests/test_log_filters.py

@@ -23,9 +23,8 @@ def test_suppress_mode(self):
     @patch.dict('os.environ', {'DEBUG_MODE_TOKEN_FILTER': 'DEFAULT'})
     def test_default_mode_raises_warning(self):
         filter = DebugModeTokenFilter()
-        with self.assertRaises(Warning) as context:
-            filter.filter(self.record)
-        self.assertTrue("Your logger, when in DEBUG mode, will log TOKENS" in str(context.exception))
+        result = filter.filter(self.record)
+        self.assertTrue(result)
 
 if __name__ == '__main__':
     unittest.main()