Skip to content

Commit 07d198e

Browse files
authored
Update to Rerun 0.24.0 (#23)
* Update to Rerun 0.24.0 * Silence a warning * Silence warning on GCC too * Revert "Treat warnings as errors" This reverts commit e5005c0.
1 parent e5005c0 commit 07d198e

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

CMakeLists.txt

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
cmake_minimum_required(VERSION 3.16...3.27)
22

3-
set(CMAKE_COMPILE_WARNING_AS_ERROR ON)
3+
set(CMAKE_COMPILE_WARNING_AS_ERROR OFF) # TODO(emilk): If we turn this ON, VRS fails to compile
44

55
set(TARGET_NAME rerun_vrs_example)
66
project(${TARGET_NAME} LANGUAGES CXX)
@@ -13,7 +13,7 @@ endif()
1313

1414
# Rerun:
1515
include(FetchContent)
16-
FetchContent_Declare(rerun_sdk URL https://github.com/rerun-io/rerun/releases/download/0.23.0/rerun_cpp_sdk.zip)
16+
FetchContent_Declare(rerun_sdk URL https://github.com/rerun-io/rerun/releases/download/0.24.0/rerun_cpp_sdk.zip)
1717
FetchContent_MakeAvailable(rerun_sdk)
1818

1919
# VRS:
@@ -61,6 +61,7 @@ else()
6161
-Wcast-qual
6262
-Wdeprecated
6363
-Wdeprecated-declarations
64+
-Werror=deprecated-declarations
6465
-Wextra
6566
-Wformat=2
6667
-Wmissing-include-dirs
@@ -102,12 +103,16 @@ else()
102103
-Wno-padded
103104
-Wno-reserved-id-macro
104105
-Wno-reserved-identifier
105-
-Wno-unused-macros
106-
-Wno-unsafe-buffer-usage # Not sure why we need this, but we do.
107106
-Wno-unknown-warning-option # Otherwise older clang will complain about `-Wno-unsafe-buffer-usage`
107+
-Wno-unsafe-buffer-usage # Not sure why we need this, but we do.
108+
-Wno-unused-macros
108109
)
109110
endif()
110111

112+
target_compile_options(${TARGET_NAME} PRIVATE
113+
-Wno-return-type # VRS fails this
114+
)
115+
111116
# CMAKE_COMPILE_WARNING_AS_ERROR is only directly supported starting in CMake `3.24`
112117
# https://cmake.org/cmake/help/latest/prop_tgt/COMPILE_WARNING_AS_ERROR.html
113118
if(CMAKE_COMPILE_WARNING_AS_ERROR)

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ If you choose not to use pixi, you will need to install a few things yourself be
2929
The Rerun C++ SDK works by connecting to an awaiting Rerun Viewer over TCP.
3030

3131
If you need to install the viewer, follow the [installation guide](https://www.rerun.io/docs/getting-started/installing-viewer). Two of the more common ways to install the Rerun Viewer are:
32-
* Via cargo: `cargo install rerun-cli@0.23.0 --locked`
33-
* Via pip: `pip install rerun-sdk==0.23.0`
32+
* Via cargo: `cargo install rerun-cli@0.24.0 --locked`
33+
* Via pip: `pip install rerun-sdk==0.24.0`
3434

3535
After you have installed it, you should be able to type `rerun` in your terminal to start the viewer.
3636

0 commit comments

Comments
 (0)