Skip to content

Commit 4c7c448

Browse files
committed
Clarify assumptions for stride-free Image logging
1 parent c4ac493 commit 4c7c448

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/FramePlayer.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,9 @@ namespace rerun_vrs {
7777

7878
if (frameValid) {
7979
// Log image to Rerun
80-
// NOTE currently we need to construct a vector to log an image, this will
81-
// change in the future, see https://github.com/rerun-io/rerun/issues/3794
80+
// NOTE Rerun assumes row major ordering for Images (i.e., TensorData) without any stride.
81+
// Right now we don't check this properly, and just assume that there is no extra padding
82+
// per pixel and / or per row.
8283
rec_.log(
8384
add_quotes(id_.getName()).c_str(),
8485
rerun::Image(

0 commit comments

Comments
 (0)