diff --git a/CMakeLists.txt b/CMakeLists.txt index 80c3665..4616999 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,6 +1,6 @@ cmake_minimum_required(VERSION 3.16...3.27) -set(CMAKE_COMPILE_WARNING_AS_ERROR ON) +set(CMAKE_COMPILE_WARNING_AS_ERROR OFF) # TODO(emilk): If we turn this ON, VRS fails to compile set(TARGET_NAME rerun_vrs_example) project(${TARGET_NAME} LANGUAGES CXX) @@ -13,7 +13,7 @@ endif() # Rerun: include(FetchContent) -FetchContent_Declare(rerun_sdk URL https://github.com/rerun-io/rerun/releases/download/0.23.0/rerun_cpp_sdk.zip) +FetchContent_Declare(rerun_sdk URL https://github.com/rerun-io/rerun/releases/download/0.24.0/rerun_cpp_sdk.zip) FetchContent_MakeAvailable(rerun_sdk) # VRS: @@ -61,6 +61,7 @@ else() -Wcast-qual -Wdeprecated -Wdeprecated-declarations + -Werror=deprecated-declarations -Wextra -Wformat=2 -Wmissing-include-dirs @@ -102,12 +103,16 @@ else() -Wno-padded -Wno-reserved-id-macro -Wno-reserved-identifier - -Wno-unused-macros - -Wno-unsafe-buffer-usage # Not sure why we need this, but we do. -Wno-unknown-warning-option # Otherwise older clang will complain about `-Wno-unsafe-buffer-usage` + -Wno-unsafe-buffer-usage # Not sure why we need this, but we do. + -Wno-unused-macros ) endif() + target_compile_options(${TARGET_NAME} PRIVATE + -Wno-return-type # VRS fails this + ) + # CMAKE_COMPILE_WARNING_AS_ERROR is only directly supported starting in CMake `3.24` # https://cmake.org/cmake/help/latest/prop_tgt/COMPILE_WARNING_AS_ERROR.html if(CMAKE_COMPILE_WARNING_AS_ERROR) diff --git a/README.md b/README.md index d5439ae..24ede3e 100644 --- a/README.md +++ b/README.md @@ -29,8 +29,8 @@ If you choose not to use pixi, you will need to install a few things yourself be The Rerun C++ SDK works by connecting to an awaiting Rerun Viewer over TCP. If you need to install the viewer, follow the [installation guide](https://www.rerun.io/docs/getting-started/installing-viewer). Two of the more common ways to install the Rerun Viewer are: -* Via cargo: `cargo install rerun-cli@0.23.0 --locked` -* Via pip: `pip install rerun-sdk==0.23.0` +* Via cargo: `cargo install rerun-cli@0.24.0 --locked` +* Via pip: `pip install rerun-sdk==0.24.0` After you have installed it, you should be able to type `rerun` in your terminal to start the viewer.