Skip to content

Commit 064dab5

Browse files
authored
Improve warning message on accidental component type change (#11456)
### What Title.
1 parent d88658b commit 064dab5

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

crates/store/re_chunk/src/iter.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ where
347347
{
348348
let Some(values) = array.downcast_array_ref::<ArrowPrimitiveArray<P>>() else {
349349
if cfg!(debug_assertions) {
350-
panic!("downcast failed for {component_descriptor}, data discarded");
350+
panic!("[DEBUG ASSERT] downcast failed for {component_descriptor}, data discarded");
351351
} else {
352352
re_log::error_once!("downcast failed for {component_descriptor}, data discarded");
353353
}

crates/store/re_chunk_store/src/writes.rs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -382,9 +382,12 @@ impl ChunkStore {
382382
&& old_typ != list_array.value_type()
383383
{
384384
re_log::warn_once!(
385-
"Component column '{}' changed type from {old_typ:?} to {:?}",
385+
"Component '{}' with component type '{}' on entity '{}' changed type from {} to {}",
386+
component_descr.component,
386387
component_type,
387-
list_array.value_type()
388+
chunk.entity_path(),
389+
re_arrow_util::format_data_type(&old_typ),
390+
re_arrow_util::format_data_type(&list_array.value_type())
388391
);
389392
}
390393

0 commit comments

Comments
 (0)