Enable more Python lints (#11329)

Author: emilk

docs/snippets/all/tutorials/custom_data.py

@@ -36,10 +36,10 @@ def __init__(self: Any, positions: npt.ArrayLike, confidences: npt.ArrayLike) ->
         )
 
     def as_component_batches(self) -> list[rr.DescribedComponentBatch]:
-        return (
-            list(self.points3d.as_component_batches())  # The components from Points3D
-            + [self.confidences]  # Custom confidence data
-        )
+        return [
+            *self.points3d.as_component_batches(),  # The components from Points3D
+            self.confidences,  # Custom confidence data
+        ]
 
 
 def log_custom_data() -> None:

docs/snippets/compare_snippet_output.py

@@ -18,7 +18,7 @@
 import tomlkit
 
 sys.path.append(os.path.dirname(os.path.realpath(__file__)) + "/../../scripts/")
-from roundtrip_utils import roundtrip_env, run, run_comparison  # noqa
+from roundtrip_utils import roundtrip_env, run, run_comparison
 
 if TYPE_CHECKING:
     from tomlkit.container import Container
@@ -148,7 +148,11 @@ def main() -> None:
             if name == "__init__.py":
                 continue
             name, extension = os.path.splitext(name)
-            if extension == ".cpp" and not args.no_cpp or extension == ".py" and not args.no_py or extension == ".rs":
+            if (
+                (extension == ".cpp" and not args.no_cpp)
+                or (extension == ".py" and not args.no_py)
+                or extension == ".rs"
+            ):
                 subdir = os.path.relpath(os.path.dirname(file), dir)
                 examples += [Example(subdir.replace("\\", "/"), name)]
 
@@ -299,7 +303,7 @@ def build_rust_snippets(build_env: dict[str, str], release: bool, target: str |
     run(cmd, env=build_env, timeout=12000)
     elapsed = time.time() - start_time
     print(f"Snippets built in {elapsed:.1f} seconds")
-    print("")
+    print()
 
 
 def build_python_sdk(build_env: dict[str, str]) -> None:
@@ -309,7 +313,7 @@ def build_python_sdk(build_env: dict[str, str]) -> None:
     run(["pixi", "run", "py-build", "--quiet"], env=build_env, timeout=12000)
     elapsed = time.time() - start_time
     print(f"rerun-sdk for Python built in {elapsed:.1f} seconds")
-    print("")
+    print()
 
 
 def build_cpp_snippets() -> None:
@@ -319,7 +323,7 @@ def build_cpp_snippets() -> None:
     run(["pixi", "run", "-e", "cpp", "cpp-build-snippets"], timeout=12000)
     elapsed = time.time() - start_time
     print(f"rerun-sdk for C++ built in {elapsed:.1f} seconds")
-    print("")
+    print()
 
 
 def run_python(example: Example) -> str:
@@ -331,7 +335,7 @@ def run_python(example: Example) -> str:
     if python_executable is None:
         python_executable = "python3"
 
-    cmd = [python_executable, main_path] + example.extra_args()
+    cmd = [python_executable, main_path, *example.extra_args()]
 
     env = roundtrip_env(save_path=output_path)
     run(cmd, env=env, timeout=30)
@@ -368,7 +372,7 @@ def run_prebuilt_cpp(example: Example) -> str:
     output_path = example.output_path("cpp")
 
     extension = ".exe" if os.name == "nt" else ""
-    cmd = [f"./build/debug/docs/snippets/{example.name}{extension}"] + example.extra_args()
+    cmd = [f"./build/debug/docs/snippets/{example.name}{extension}", *example.extra_args()]
     env = roundtrip_env(save_path=output_path)
     run(cmd, env=env, timeout=30)
 

examples/python/depth_guided_stable_diffusion/depth_guided_stable_diffusion/__main__.py

@@ -30,11 +30,8 @@
 
 IMAGE_NAME_TO_URL: Final = {
     "sitting_wooden_figure": "https://storage.googleapis.com/rerun-example-datasets/stable_diffusion/sitting_wooden_figure.jpg",
-    # noqa: E501 line too long
     "old_man": "https://github.com/Stability-AI/stablediffusion/raw/main/assets/stable-samples/depth2img/old_man.png",
-    # noqa: E501 line too long
     "fantasy": "https://github.com/Stability-AI/stablediffusion/raw/main/assets/stable-samples/depth2img/depth2fantasy.jpeg",
-    # noqa: E501 line too long
 }
 IMAGE_NAMES: Final = list(IMAGE_NAME_TO_URL.keys())
 
@@ -52,8 +49,7 @@ def get_downloaded_path(dataset_dir: Path, image_name: str) -> str:
     with requests.get(image_url, stream=True) as req:
         req.raise_for_status()
         with open(destination_path, "wb") as f:
-            for chunk in req.iter_content(chunk_size=8192):
-                f.write(chunk)
+            f.writelines(req.iter_content(chunk_size=8192))
     return str(destination_path)
 
 

examples/python/detect_and_track_objects/detect_and_track_objects.py

@@ -402,8 +402,7 @@ def get_downloaded_path(dataset_dir: Path, video_name: str) -> str:
     with requests.get(source_path, stream=True) as req:
         req.raise_for_status()
         with open(destination_path, "wb") as f:
-            for chunk in req.iter_content(chunk_size=8192):
-                f.write(chunk)
+            f.writelines(req.iter_content(chunk_size=8192))
     return str(destination_path)
 
 

examples/python/external_data_loader/rerun-loader-python-file.py

@@ -5,6 +5,7 @@
 
 import argparse
 import os
+import sys
 
 import rerun as rr  # pip install rerun-sdk
 
@@ -63,7 +64,7 @@ def main() -> None:
 
     # Inform the Rerun Viewer that we do not support that kind of file.
     if not is_file or not is_python_file:
-        exit(rr.EXTERNAL_DATA_LOADER_INCOMPATIBLE_EXIT_CODE)
+        sys.exit(rr.EXTERNAL_DATA_LOADER_INCOMPATIBLE_EXIT_CODE)
 
     app_id = "rerun_example_external_data_loader"
     if args.application_id is not None:

examples/python/human_pose_tracking/human_pose_tracking.py

@@ -193,8 +193,7 @@ def download(url: str, destination_path: Path) -> None:
     with requests.get(url, stream=True) as req:
         req.raise_for_status()
         with open(destination_path, "wb") as f:
-            for chunk in req.iter_content(chunk_size=8192):
-                f.write(chunk)
+            f.writelines(req.iter_content(chunk_size=8192))
 
 
 def main() -> None:

examples/python/imu_signals/imu_signals.py

@@ -77,7 +77,7 @@ def _download_dataset(root: Path, dataset_url: str = DATASET_URL) -> None:
                 pb.update(len(data))
                 file.write(data)
 
-    if total_size != 0 and pb.n != total_size:
+    if total_size not in (0, pb.n):
         raise RuntimeError("Failed to download complete dataset!")
 
     print("Extracting dataset…")

examples/python/lidar/lidar/__main__.py

@@ -3,6 +3,7 @@
 
 import argparse
 import pathlib
+import sys
 from typing import Final
 
 import matplotlib
@@ -40,7 +41,7 @@ def ensure_scene_available(root_dir: pathlib.Path, dataset_version: str, scene_n
             nusc = nuscenes.NuScenes(version=dataset_version, dataroot=root_dir, verbose=True)
         else:
             print(f"Could not find dataset at {root_dir} and could not automatically download specified scene.")
-            exit()
+            sys.exit()
 
     scene_names = [s["name"] for s in nusc.scene]
     if scene_name not in scene_names:

examples/python/multiprocess_logging/multiprocess_logging.py

@@ -31,7 +31,7 @@ def task(child_index: int) -> None:
         "log",
         rr.TextLog(
             f"Logging from pid={os.getpid()}, thread={threading.get_ident()} using the rerun recording id {rr.get_recording_id()}",
-        ),  # noqa: E501 line too long
+        ),
     )
     if child_index == 0:
         rr.log(title, rr.Boxes2D(array=[5, 5, 80, 80], array_format=rr.Box2DFormat.XYWH, labels=title))

examples/python/nuscenes_dataset/nuscenes_dataset/__main__.py

@@ -3,6 +3,7 @@
 
 import argparse
 import pathlib
+import sys
 from typing import Any, Final
 
 import matplotlib
@@ -51,7 +52,7 @@ def ensure_scene_available(root_dir: pathlib.Path, dataset_version: str, scene_n
             nusc = nuscenes.NuScenes(version=dataset_version, dataroot=root_dir, verbose=True)
         else:
             print(f"Could not find dataset at {root_dir} and could not automatically download specified scene.")
-            exit()
+            sys.exit()
 
     scene_names = [s["name"] for s in nusc.scene]
     if scene_name not in scene_names: