Use Display for DataTypes, not Debug formatting (#11219)

Author: emilk

Cargo.lock

@@ -7421,6 +7421,7 @@ dependencies = [
  "egui_extras",
  "itertools 0.14.0",
  "re_arrow_ui",
+ "re_arrow_util",
  "re_byte_size",
  "re_chunk_store",
  "re_format",

crates/store/re_data_loader/src/loader_lerobot.rs

@@ -600,7 +600,7 @@ fn make_scalar_entity_chunk(
 fn extract_scalar_slices_as_f64(data: &ArrayRef) -> anyhow::Result<Vec<ArrayRef>> {
     // cast the slice to f64 first, as scalars need an f64
     let scalar_values = cast(&data, &DataType::Float64)
-        .with_context(|| format!("Failed to cast {:?} to Float64", data.data_type()))?;
+        .with_context(|| format!("Failed to cast {} to Float64", data.data_type()))?;
 
     Ok((0..data.len())
         .map(|idx| scalar_values.slice(idx, 1))
@@ -613,7 +613,7 @@ fn extract_fixed_size_list_array_elements_as_f64(
     (0..data.len())
         .map(|idx| {
             cast(&data.value(idx), &DataType::Float64)
-                .with_context(|| format!("Failed to cast {:?} to Float64", data.data_type()))
+                .with_context(|| format!("Failed to cast {} to Float64", data.data_type()))
         })
         .collect::<Result<Vec<_>, _>>()
 }
@@ -624,7 +624,7 @@ fn extract_list_array_elements_as_f64(
     (0..data.len())
         .map(|idx| {
             cast(&data.value(idx), &DataType::Float64)
-                .with_context(|| format!("Failed to cast {:?} to Float64", data.data_type()))
+                .with_context(|| format!("Failed to cast {} to Float64", data.data_type()))
         })
         .collect::<Result<Vec<_>, _>>()
 }

crates/store/re_sorbet/src/index_column_descriptor.rs

@@ -5,7 +5,7 @@ use re_log_types::{Timeline, TimelineName};
 use crate::MetadataExt as _;
 
 #[derive(thiserror::Error, Debug)]
-#[error("Unsupported time type: {datatype:?}")]
+#[error("Unsupported time type: {datatype}")]
 pub struct UnsupportedTimeType {
     pub datatype: ArrowDatatype,
 }

crates/store/re_sorbet/src/row_id_column_descriptor.rs

@@ -86,7 +86,7 @@ impl TryFrom<&ArrowField> for RowIdColumnDescriptor {
             })
         } else {
             Err(WrongDatatypeError(format!(
-                "Expected a RowId column with datatype {expected_datatype:?}, but column {:?} has datatype {actual_datatype:?}",
+                "Expected a RowId column with datatype {expected_datatype}, but column {:?} has datatype {actual_datatype}",
                 field.name()
             )))
         }

crates/store/re_types/src/archetypes/depth_image_ext.rs

@@ -50,7 +50,7 @@ impl DepthImage {
         let num_expected_bytes = image_format.num_bytes();
         if buffer.len() != num_expected_bytes {
             re_log::warn_once!(
-                "Expected {width}x{height} {} {datatype:?} image to be {num_expected_bytes} B, but got {} B",
+                "Expected {width}x{height} {} {datatype} image to be {num_expected_bytes} B, but got {} B",
                 ColorModel::L,
                 buffer.len()
             );

crates/store/re_types/src/archetypes/image_ext.rs

@@ -99,7 +99,7 @@ impl Image {
         let num_expected_bytes = image_format.num_bytes();
         if buffer.len() != num_expected_bytes {
             re_log::warn_once!(
-                "Expected {width}x{height} {color_model:?} {datatype:?} image to be {num_expected_bytes} B, but got {} B",
+                "Expected {width}x{height} {color_model:?} {datatype} image to be {num_expected_bytes} B, but got {} B",
                 buffer.len()
             );
         }

crates/store/re_types/src/components/image_buffer_ext.rs

@@ -20,7 +20,7 @@ impl ImageBuffer {
         let num_expected_bytes = image_format.num_bytes();
         if bytes.len() != num_expected_bytes {
             re_log::warn_once!(
-                "Expected {width}x{height} {color_model:?} {datatype:?} image to be {num_expected_bytes} B, but got {} B",
+                "Expected {width}x{height} {color_model:?} {datatype} image to be {num_expected_bytes} B, but got {} B",
                 bytes.len()
             );
         }

crates/store/re_types_core/src/reflection.rs

@@ -95,7 +95,7 @@ pub fn generic_placeholder_for_datatype(
 
             TimeUnit::Microsecond | TimeUnit::Nanosecond => {
                 re_log::debug_once!(
-                    "Attempted to create a placeholder for out-of-spec datatype: {datatype:?}"
+                    "Attempted to create a placeholder for out-of-spec datatype: {datatype}"
                 );
                 array::new_empty_array(datatype)
             }
@@ -112,7 +112,7 @@ pub fn generic_placeholder_for_datatype(
 
             TimeUnit::Second | TimeUnit::Millisecond => {
                 re_log::debug_once!(
-                    "Attempted to create a placeholder for out-of-spec datatype: {datatype:?}"
+                    "Attempted to create a placeholder for out-of-spec datatype: {datatype}"
                 );
                 array::new_empty_array(datatype)
             }
@@ -198,7 +198,7 @@ pub fn generic_placeholder_for_datatype(
             {
                 Arc::new(array::FixedSizeListArray::from(list_data))
             } else {
-                re_log::warn_once!("Bug in FixedSizeListArray of {:?}", field.data_type());
+                re_log::warn_once!("Bug in FixedSizeListArray of {}", field.data_type());
                 array::new_empty_array(datatype)
             }
         }
@@ -245,7 +245,7 @@ pub fn generic_placeholder_for_datatype(
         | DataType::LargeListView { .. }
         | DataType::RunEndEncoded { .. } => {
             // TODO(emilk)
-            re_log::debug_once!("Unimplemented: placeholder value for: {datatype:?}");
+            re_log::debug_once!("Unimplemented: placeholder value for: {datatype}");
             array::new_empty_array(datatype) // TODO(emilk)
         }
     }

crates/store/re_types_core/src/result.rs

@@ -142,7 +142,7 @@ pub enum DeserializationError {
     #[error("Expected non-nullable data but didn't find any")]
     MissingData { backtrace: Box<_Backtrace> },
 
-    #[error("Expected field {field_name:?} to be present in {datatype:#?}")]
+    #[error("Expected field {field_name:?} to be present in {datatype}")]
     MissingStructField {
         datatype: arrow::datatypes::DataType,
         field_name: String,
@@ -160,15 +160,15 @@ pub enum DeserializationError {
         backtrace: Box<_Backtrace>,
     },
 
-    #[error("Expected union arm {arm_name:?} (#{arm_index}) to be present in {datatype:#?}")]
+    #[error("Expected union arm {arm_name:?} (#{arm_index}) to be present in {datatype}")]
     MissingUnionArm {
         datatype: arrow::datatypes::DataType,
         arm_name: String,
         arm_index: usize,
         backtrace: Box<_Backtrace>,
     },
 
-    #[error("Expected {expected:#?} but found {got:#?} instead")]
+    #[error("Expected {expected} but found {got} instead")]
     DatatypeMismatch {
         expected: arrow::datatypes::DataType,
         got: arrow::datatypes::DataType,

crates/top/rerun/src/commands/rrd/verify.rs

@@ -140,7 +140,7 @@ impl Verifier {
             }
 
             let list_array = column.as_list_opt::<i32>().ok_or_else(|| {
-                anyhow::anyhow!("Expected list array, found {:?}", column.data_type())
+                anyhow::anyhow!("Expected list array, found {}", column.data_type())
             })?;
 
             assert_eq!(column.len() + 1, list_array.offsets().len());