@@ -285,7 +285,6 @@ impl TransformForest {
285
285
root_from_parent * transforms_at_entity. parent_from_entity_tree_transform ;
286
286
287
287
// Did we encounter a pinhole and need to create a new subspace?
288
- // TODO: report nested pinholes
289
288
let ( root, root_from_entity) =
290
289
if let Some ( pinhole_projection) = transforms_at_entity. pinhole_projection {
291
290
let new_root = child_path. hash ( ) ;
@@ -529,7 +528,6 @@ fn from_3d_source_to_2d_target(
529
528
// The inverse of this matrix *is* working for this, but quickly runs into precision issues.
530
529
// See also `ui_2d.rs#setup_target_config`
531
530
532
- // TODO: Locally cache pinhole transform?
533
531
let pinhole3d_from_image_plane =
534
532
pinhole3d_from_image_plane ( pinhole_projection, pinhole_image_plane_distance) ;
535
533
let image_plane_from_pinhole3d = pinhole3d_from_image_plane. inverse ( ) ;
@@ -687,7 +685,7 @@ mod tests {
687
685
/// A test scene that relies exclusively on the entity hierarchy.
688
686
///
689
687
/// We're using relatively basic transforms here as we assume that resolving transforms have been tested on [`TransformResolutionCache`] already.
690
- /// Similarly, since [`TransformForest`] does not yet mantain anything over time, we're using static timeing instead.
688
+ /// Similarly, since [`TransformForest`] does not yet maintain anything over time, we're using static timing instead.
691
689
/// TODO(RR-2510): add another scene (or extension) where we override transforms on select entities
692
690
/// TODO(RR-2511): add a scene with frame relationships
693
691
fn entity_hierarchy_test_scene ( ) -> EntityDb {
@@ -760,7 +758,7 @@ mod tests {
760
758
entity_db
761
759
}
762
760
763
- fn pretty_print_enity_path_hashes_in < T : std:: fmt:: Debug > (
761
+ fn pretty_print_entity_path_hashes_in < T : std:: fmt:: Debug > (
764
762
obj : T ,
765
763
paths : & [ EntityPath ] ,
766
764
) -> String {
@@ -799,7 +797,7 @@ mod tests {
799
797
// Pinhole roots are a bit more complex. Let's use `insta` to verify.
800
798
insta:: assert_snapshot!(
801
799
"simple_entity_hierarchy__root_info_pinhole" ,
802
- pretty_print_enity_path_hashes_in (
800
+ pretty_print_entity_path_hashes_in (
803
801
transform_forest. root_info( EntityPath :: from( "top/pinhole" ) . hash( ) ) ,
804
802
& all_entity_paths
805
803
)
@@ -860,7 +858,7 @@ mod tests {
860
858
861
859
insta:: assert_snapshot!(
862
860
format!( "simple_entity_hierarchy__transform_from_to_{}" , name) ,
863
- pretty_print_enity_path_hashes_in (
861
+ pretty_print_entity_path_hashes_in (
864
862
transform_forest
865
863
. transform_from_to( target. hash( ) , sources. iter( ) . map( |s| s. hash( ) ) , & |_| {
866
864
1.0
0 commit comments