Skip to content

Commit 758e9b5

Browse files
committed
typo fixes
1 parent 00ea179 commit 758e9b5

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

crates/store/re_tf/src/transform_forest.rs

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,6 @@ impl TransformForest {
285285
root_from_parent * transforms_at_entity.parent_from_entity_tree_transform;
286286

287287
// Did we encounter a pinhole and need to create a new subspace?
288-
// TODO: report nested pinholes
289288
let (root, root_from_entity) =
290289
if let Some(pinhole_projection) = transforms_at_entity.pinhole_projection {
291290
let new_root = child_path.hash();
@@ -529,7 +528,6 @@ fn from_3d_source_to_2d_target(
529528
// The inverse of this matrix *is* working for this, but quickly runs into precision issues.
530529
// See also `ui_2d.rs#setup_target_config`
531530

532-
// TODO: Locally cache pinhole transform?
533531
let pinhole3d_from_image_plane =
534532
pinhole3d_from_image_plane(pinhole_projection, pinhole_image_plane_distance);
535533
let image_plane_from_pinhole3d = pinhole3d_from_image_plane.inverse();
@@ -687,7 +685,7 @@ mod tests {
687685
/// A test scene that relies exclusively on the entity hierarchy.
688686
///
689687
/// We're using relatively basic transforms here as we assume that resolving transforms have been tested on [`TransformResolutionCache`] already.
690-
/// Similarly, since [`TransformForest`] does not yet mantain anything over time, we're using static timeing instead.
688+
/// Similarly, since [`TransformForest`] does not yet maintain anything over time, we're using static timing instead.
691689
/// TODO(RR-2510): add another scene (or extension) where we override transforms on select entities
692690
/// TODO(RR-2511): add a scene with frame relationships
693691
fn entity_hierarchy_test_scene() -> EntityDb {
@@ -760,7 +758,7 @@ mod tests {
760758
entity_db
761759
}
762760

763-
fn pretty_print_enity_path_hashes_in<T: std::fmt::Debug>(
761+
fn pretty_print_entity_path_hashes_in<T: std::fmt::Debug>(
764762
obj: T,
765763
paths: &[EntityPath],
766764
) -> String {
@@ -799,7 +797,7 @@ mod tests {
799797
// Pinhole roots are a bit more complex. Let's use `insta` to verify.
800798
insta::assert_snapshot!(
801799
"simple_entity_hierarchy__root_info_pinhole",
802-
pretty_print_enity_path_hashes_in(
800+
pretty_print_entity_path_hashes_in(
803801
transform_forest.root_info(EntityPath::from("top/pinhole").hash()),
804802
&all_entity_paths
805803
)
@@ -860,7 +858,7 @@ mod tests {
860858

861859
insta::assert_snapshot!(
862860
format!("simple_entity_hierarchy__transform_from_to_{}", name),
863-
pretty_print_enity_path_hashes_in(
861+
pretty_print_entity_path_hashes_in(
864862
transform_forest
865863
.transform_from_to(target.hash(), sources.iter().map(|s| s.hash()), &|_| {
866864
1.0

0 commit comments

Comments
 (0)