fixing tests

Author: IsseW

crates/viewer/re_component_ui/tests/snapshots/all_components_list_item_narrow/TimeCell_placeholder.png

@@ -1098,7 +1098,10 @@ mod tests {
         TimeType,
         example_components::{MyPoint, MyPoints},
     };
-    use re_test_context::{TestContext, external::egui_kittest::SnapshotOptions};
+    use re_test_context::{
+        TestContext,
+        external::egui_kittest::{SnapshotOptions, kittest::Queryable as _},
+    };
     use re_test_viewport::{TestContextExt as _, TestView};
     use re_types::archetypes;
     use re_viewer_context::{RecommendedView, ViewClass as _, blueprint_timeline};
@@ -1182,10 +1185,7 @@ mod tests {
                 test_context.handle_system_commands();
             });
 
-        let raw_input = harness.input_mut();
-        raw_input
-            .events
-            .push(egui::Event::PointerMoved(egui::Pos2 { x: 120.0, y: 80.0 }));
+        harness.get_by_label("test_app").hover();
 
         harness.run();
 

crates/viewer/re_component_ui/tests/snapshots/all_components_list_item_wide/TimeCell_placeholder.png

@@ -184,16 +184,31 @@ impl TestContext {
 
         let (command_sender, command_receiver) = command_channel();
 
-        let recording_config = RecordingConfig::default();
-
         let blueprint_query = LatestAtQuery::latest(blueprint_timeline());
 
+        let recording_config = {
+            let ctx = TestBlueprintCtx {
+                command_sender: &command_sender,
+                current_blueprint: store_hub
+                    .active_blueprint()
+                    .expect("We should have an active blueprint now"),
+                default_blueprint: store_hub.default_blueprint_for_app(
+                    store_hub
+                        .active_app()
+                        .expect("We should have an active app now"),
+                ),
+                blueprint_query: &blueprint_query,
+            };
+
+            RecordingConfig::from_blueprint(&ctx)
+        };
+
         let component_ui_registry = ComponentUiRegistry::new();
 
         let reflection =
             re_types::reflection::generate_reflection().expect("Failed to generate reflection");
 
-        let this = Self {
+        Self {
             app_options: Default::default(),
 
             view_class_registry: Default::default(),
@@ -215,13 +230,7 @@ impl TestContext {
             called_setup_kittest_for_rendering: AtomicBool::new(false),
 
             store_hub: Mutex::new(store_hub),
-        };
-
-        this.with_blueprint_ctx(|ctx| {
-            ctx.set_timeline("log_tick".into());
-        });
-
-        this
+        }
     }
 
     /// Create a new test context that knows about a specific view class.
@@ -448,6 +457,7 @@ impl TestContext {
             .callback_resources
             .get_mut::<re_renderer::RenderContext>()
             .expect("No re_renderer::RenderContext in egui_render_state");
+
         render_ctx.begin_frame();
 
         let mut selection_state = self.selection_state.lock();
@@ -485,6 +495,14 @@ impl TestContext {
             drag_and_drop_manager: &drag_and_drop_manager,
         };
 
+        self.recording_config.time_ctrl.write().update(
+            store_context.recording.times_per_timeline(),
+            0.0,
+            false,
+            true,
+            &ctx,
+        );
+
         func(&ctx);
 
         // If re_renderer was used, `setup_kittest_for_rendering` should have been called.

crates/viewer/re_selection_panel/src/selection_panel.rs

@@ -1,6 +1,6 @@
 use std::sync::Arc;
 
-use re_chunk::{Chunk, RowId};
+use re_chunk::{Chunk, RowId, TimePoint};
 use re_chunk_store::LatestAtQuery;
 use re_entity_db::EntityDb;
 use re_log_types::EntityPath;
@@ -203,19 +203,9 @@ pub fn setup_welcome_screen_blueprint(welcome_screen_blueprint: &mut EntityDb) {
         (SELECTION_PANEL_PATH, PanelState::Hidden),
         (TIME_PANEL_PATH, PanelState::Hidden),
     ] {
-        let entity_path = EntityPath::from(panel_name);
-
         let timepoint = re_viewer_context::blueprint_timepoint_for_writes(welcome_screen_blueprint);
 
-        let chunk = Chunk::builder(entity_path)
-            .with_archetype(
-                RowId::new(),
-                timepoint,
-                &PanelBlueprint::update_fields().with_state(value),
-            )
-            .build()
-            // All builtin types, no reason for this to ever fail.
-            .expect("Failed to build chunk.");
+        let chunk = get_panel_state_chunk(panel_name, timepoint, value);
 
         welcome_screen_blueprint
             .add_chunk(&Arc::new(chunk))
@@ -233,21 +223,9 @@ impl AppBlueprint<'_> {
         command_sender: &CommandSender,
     ) {
         if let Some(blueprint_db) = self.blueprint_db {
-            let entity_path = EntityPath::from(panel_name);
-
             let timepoint = blueprint_timepoint_for_writes(blueprint_db);
 
-            let component_update: &dyn AsComponents = if panel_name == TIME_PANEL_PATH {
-                &TimePanelBlueprint::update_fields().with_state(value)
-            } else {
-                &PanelBlueprint::update_fields().with_state(value)
-            };
-
-            let chunk = Chunk::builder(entity_path)
-                .with_archetype(RowId::new(), timepoint, component_update)
-                .build()
-                // All builtin types, no reason for this to ever fail.
-                .expect("Failed to build chunk.");
+            let chunk = get_panel_state_chunk(panel_name, timepoint, value);
 
             command_sender.send_system(SystemCommand::AppendToStore(
                 blueprint_db.store_id().clone(),
@@ -257,6 +235,22 @@ impl AppBlueprint<'_> {
     }
 }
 
+fn get_panel_state_chunk(panel_name: &str, timepoint: TimePoint, value: PanelState) -> Chunk {
+    let entity_path = EntityPath::from(panel_name);
+
+    let component_update: &dyn AsComponents = if panel_name == TIME_PANEL_PATH {
+        &TimePanelBlueprint::update_fields().with_state(value)
+    } else {
+        &PanelBlueprint::update_fields().with_state(value)
+    };
+
+    Chunk::builder(entity_path)
+        .with_archetype(RowId::new(), timepoint, component_update)
+        .build()
+        // All builtin types, no reason for this to ever fail.
+        .expect("Failed to build chunk.")
+}
+
 fn load_panel_state(
     path: &EntityPath,
     blueprint_db: &re_entity_db::EntityDb,

crates/viewer/re_test_context/src/lib.rs

@@ -468,14 +468,14 @@ def __init__(
             The time cursor for a timestamp timeline.
 
         """
+        super().__init__(blueprint_path="time_panel", expanded=expanded, state=state)
+        self.timeline = timeline
+
         if sum(x is not None for x in (sequence_cursor, duration_cursor, timestamp_cursor)) > 1:
             raise ValueError(
                 "At most one of `sequence`, `duration`, and `timestamp` must be set",
             )
 
-        super().__init__(blueprint_path="time_panel", expanded=expanded, state=state)
-        self.timeline = timeline
-
         if sequence_cursor is not None:
             self.time = sequence_cursor
         elif duration_cursor is not None: