Add context menu button to copy partition name (#11378)

Author: IsseW

Cargo.lock

@@ -9154,6 +9154,7 @@ dependencies = [
  "itertools 0.14.0",
  "re_data_ui",
  "re_entity_db",
+ "re_log",
  "re_log_types",
  "re_redap_browser",
  "re_smart_channel",

crates/viewer/re_data_ui/src/item_ui.rs

@@ -797,13 +797,22 @@ pub fn entity_db_button_ui(
                 .and_then(|url| url.sharable_url(None));
         if ui
             .add_enabled(url.is_ok(), egui::Button::new("Copy link to partition"))
-            .on_disabled_hover_text("Can't copy a link to this partition")
+            .on_disabled_hover_text(if let Err(err) = url.as_ref() {
+                format!("Can't copy a link to this partition: {err}")
+            } else {
+                "Can't copy a link to this partition".to_owned()
+            })
             .clicked()
             && let Ok(url) = url
         {
             ctx.command_sender()
                 .send_system(SystemCommand::CopyViewerUrl(url));
         }
+
+        if ui.button("Copy partition name").clicked() {
+            re_log::info!("Copied {recording_name:?} to clipboard");
+            ui.ctx().copy_text(recording_name);
+        }
     });
 
     if response.clicked() {

crates/viewer/re_dataframe_ui/src/datafusion_table_widget.rs

@@ -17,7 +17,9 @@ use re_log_types::{EntryId, TimelineName, Timestamp};
 use re_sorbet::{ColumnDescriptorRef, SorbetSchema};
 use re_ui::menu::menu_style;
 use re_ui::{UiExt as _, icons};
-use re_viewer_context::{AsyncRuntimeHandle, ViewerContext};
+use re_viewer_context::{
+    AsyncRuntimeHandle, SystemCommand, SystemCommandSender as _, ViewerContext,
+};
 
 use crate::datafusion_adapter::{DataFusionAdapter, DataFusionQueryResult};
 use crate::display_record_batch::DisplayColumn;
@@ -380,7 +382,14 @@ impl<'a> DataFusionTableWidget<'a> {
         );
 
         if let Some(title) = title {
-            title_ui(ui, Some(&mut table_config), title, url, should_show_spinner);
+            title_ui(
+                ui,
+                viewer_ctx,
+                Some(&mut table_config),
+                title,
+                url,
+                should_show_spinner,
+            );
         }
 
         filter_state.filter_bar_ui(
@@ -565,6 +574,7 @@ fn id_from_session_context_and_table(
 
 fn title_ui(
     ui: &mut egui::Ui,
+    ctx: &ViewerContext<'_>,
     table_config: Option<&mut TableConfig>,
     title: &str,
     url: Option<&str>,
@@ -588,7 +598,8 @@ fn title_ui(
                             .on_hover_text(url)
                             .clicked()
                     {
-                        ui.ctx().copy_text(url.into());
+                        ctx.command_sender()
+                            .send_system(SystemCommand::CopyViewerUrl(url.to_owned()));
                     }
 
                     if should_show_spinner {

crates/viewer/re_recording_panel/Cargo.toml

@@ -25,6 +25,7 @@ testing = ["dep:serde", "re_viewer_context/testing", "re_log_types/serde"]
 [dependencies]
 re_data_ui.workspace = true
 re_entity_db.workspace = true
+re_log.workspace = true
 re_log_types.workspace = true
 re_redap_browser.workspace = true
 re_smart_channel.workspace = true

crates/viewer/re_recording_panel/src/recording_panel_ui.rs

@@ -406,6 +406,17 @@ fn dataset_entry_ui(
             ctx.command_sender()
                 .send_system(SystemCommand::CopyViewerUrl(url));
         }
+
+        if ui.button("Copy dataset name").clicked() {
+            re_log::info!("Copied {name:?} to clipboard");
+            ui.ctx().copy_text(name.clone());
+        }
+
+        if ui.button("Copy dataset id").clicked() {
+            let id = entry_id.id.to_string();
+            re_log::info!("Copied {id:?} to clipboard");
+            ui.ctx().copy_text(id);
+        }
     });
 
     if item_response.clicked() {
@@ -570,13 +581,13 @@ fn receiver_ui(
     receiver: &SmartChannelSource,
     show_hierarchal: bool,
 ) {
-    let Some(string) = receiver.loading_name() else {
+    let Some(name) = receiver.loading_name() else {
         return;
     };
 
     let selected = ctx.is_selected_or_loading(&Item::DataSource(receiver.clone()));
 
-    let label_content = re_ui::list_item::LabelContent::new(string)
+    let label_content = re_ui::list_item::LabelContent::new(&name)
         .with_icon_fn(|ui, rect, _| {
             ui.put(rect, egui::Spinner::new());
         })
@@ -590,13 +601,35 @@ fn receiver_ui(
             }
         });
 
-    if show_hierarchal {
+    let response = if show_hierarchal {
         ui.list_item()
             .selected(selected)
-            .show_hierarchical(ui, label_content);
+            .show_hierarchical(ui, label_content)
     } else {
         ui.list_item()
             .selected(selected)
-            .show_flat(ui, label_content);
-    }
+            .show_flat(ui, label_content)
+    };
+
+    response.context_menu(|ui| {
+        let url = ViewerOpenUrl::from_data_source(receiver).and_then(|url| url.sharable_url(None));
+        if ui
+            .add_enabled(url.is_ok(), egui::Button::new("Copy link to partition"))
+            .on_disabled_hover_text(if let Err(err) = url.as_ref() {
+                format!("Can't copy a link to this partition: {err}")
+            } else {
+                "Can't copy a link to this partition".to_owned()
+            })
+            .clicked()
+            && let Ok(url) = url
+        {
+            ctx.command_sender()
+                .send_system(SystemCommand::CopyViewerUrl(url));
+        }
+
+        if ui.button("Copy partition name").clicked() {
+            re_log::info!("Copied {name:?} to clipboard");
+            ui.ctx().copy_text(name);
+        }
+    });
 }

crates/viewer/re_time_panel/src/time_panel.rs

@@ -1877,10 +1877,10 @@ fn copy_timeline_properties_context_menu(
                 copy_command.is_ok() && has_fragment,
                 egui::Button::new("Copy link to timestamp"),
             )
-            .on_disabled_hover_text(if copy_command.is_err() {
-                "Can't share links to the current recording"
+            .on_disabled_hover_text(if let Err(err) = copy_command.as_ref() {
+                format!("Can't share links to the current recording: {err}")
             } else {
-                "The current recording doesn't support time stamp links"
+                "The current recording doesn't support time stamp links".to_owned()
             })
             .clicked()
             && let Ok(copy_command) = copy_command