Skip to content

Commit 86df1b8

Browse files
authored
Checklist improvements (#11373)
1 parent 8d338d0 commit 86df1b8

File tree

9 files changed

+13
-66
lines changed

9 files changed

+13
-66
lines changed

crates/viewer/re_context_menu/src/actions/collapse_expand_all.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ impl ContextMenuAction for CollapseExpandAllAction {
3131

3232
/// Do we have a context menu for this item?
3333
fn supports_item(&self, ctx: &ContextMenuContext<'_>, item: &Item) -> bool {
34-
// TODO(ab): in an ideal world, we'd check the fully expended/collapsed state of the item to
34+
// TODO(ab): in an ideal world, we'd check the fully expanded/collapsed state of the item to
3535
// avoid showing a command that wouldn't have an effect but that's lots of added complexity.
3636
match item {
3737
Item::AppId(_)

crates/viewer/re_ui/src/time_drag_value.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ impl TimeDragValue {
4444
let base_time = time_range_base_time(*range.start(), span);
4545
let (unit_symbol, unit_factor) = unit_from_span(span);
4646

47-
// `abs_range` is used by the DragValue when editing an absolute time, its bound expended to
47+
// `abs_range` is used by the DragValue when editing an absolute time, its bound expanded to
4848
// the nearest unit to minimize glitches.
4949
let abs_range =
5050
round_down(*range.start(), unit_factor)..=round_up(*range.end(), unit_factor);

crates/viewer/re_view_dataframe/src/expanded_rows.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ impl<'a> ExpandedRows<'a> {
116116
total_lines % 2 == 1
117117
}
118118

119-
/// Return by how many additional lines this row is expended.
119+
/// Return by how many additional lines this row is expanded.
120120
pub(crate) fn additional_lines_for_row(&self, row_nr: u64) -> u64 {
121121
self.cache.expanded_rows.get(&row_nr).copied().unwrap_or(0)
122122
}
@@ -127,7 +127,7 @@ impl<'a> ExpandedRows<'a> {
127127
pub(crate) fn set_additional_lines_for_row(&mut self, row_nr: u64, additional_lines: u64) {
128128
// Note: don't delete the entry when set to 0, this breaks animation.
129129

130-
// If this is the first time this row is expended, we must seed the corresponding animation
130+
// If this is the first time this row is expanded, we must seed the corresponding animation
131131
// cache.
132132
if !self.cache.expanded_rows.contains_key(&row_nr) {
133133
self.egui_ctx.animate_value_with_time(

crates/viewer/re_view_dataframe/src/view_class.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ use crate::{
1919
#[derive(Default)]
2020
struct DataframeViewState {
2121
/// Cache for the expanded rows.
22-
expended_rows_cache: ExpandedRowsCache,
22+
expanded_rows_cache: ExpandedRowsCache,
2323

2424
/// List of view columns for the current query, cached here for the column visibility UI.
2525
view_columns: Option<Vec<ColumnDescriptor>>,
@@ -169,7 +169,7 @@ Configure in the selection panel:
169169
ctx,
170170
ui,
171171
&query_handle,
172-
&mut state.expended_rows_cache,
172+
&mut state.expanded_rows_cache,
173173
&query.view_id,
174174
);
175175

tests/python/release_checklist/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
# Interactive release checklist
44
Welcome to the release checklist.
55

6-
Run the testlist with:
6+
Run the checklist with:
77
```
8-
pixi run -e examples python tests/python/release_checklist/main.py
8+
pixi run -e py py-build && pixi run -e py python tests/python/release_checklist/main.py
99
```
1010

1111
### When releasing

tests/python/release_checklist/check_blueprint_bw_compat.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@
2121
2222
* Install the latest official Rerun release in a virtual env: `pip install --force rerun-sdk`.
2323
* Clear all your blueprint data: `rerun reset`.
24-
* Start Rerun and check in Menu > About that you are indeed running the version you think
25-
you're running.
24+
* Start the old `rerun` (check Menu > About that you are indeed running the old version)
2625
* Open all demos available in the welcome screen.
2726
* Play around long enough for the blueprints to be saved to disk (a few seconds).
2827
* You can check whether that's the case by listing the contents of:
@@ -34,8 +33,7 @@
3433
#### Step 2: load blueprints from previous release into new one
3534
3635
* Install the about-to-released Rerun version in a virtual env: `pip install --force rerun-sdk=whatever`.
37-
* Start Rerun and check in Menu > About that you are indeed running the version you think
38-
you're running.
36+
* Start the new Rerun (check in Menu > About that you are indeed running the new version)
3937
* Open all demos available in the welcome screen.
4038
4139
#### Step 3: does it look okay?

tests/python/release_checklist/check_colormap_edit_ui.py

Lines changed: 0 additions & 51 deletions
This file was deleted.

tests/python/release_checklist/check_context_menu_collapse_expand_all.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
1313
## Blueprint tree
1414
15-
* Right-click on Viewport and select "Collapse all". Check everything is collapsed by manually expending everything.
16-
* Right-click on Viewport and select "Collapse all" and then "Expend all". Check everything is expanded.
15+
* Right-click on Viewport and select "Collapse all". Check everything is collapsed by manually expanding everything.
16+
* Right-click on Viewport and select "Collapse all" and then "Expand all". Check everything is expanded.
1717
1818
## Streams tree
1919

tests/python/release_checklist/check_plot_overrides.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
### Component overrides
1515
1616
* Select `plots/cos`.
17-
* Override all of its properties with arbitrary values.
17+
* Under "Visualizer": Override all of its properties with arbitrary values.
1818
* Remove all these overrides.
1919
2020
### Visible time range overrides

0 commit comments

Comments
 (0)