Change floating background color to 200 from 250 for dark theme (#11331)

abey79 · emilk · web-flow · commit 8c855903b475 · 2025-09-29T11:08:24.000+02:00
Co-authored-by: Emil Ernerfeldt &lt;emil.ernerfeldt@gmail.com&gt;
diff --git a/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_boolean_equals_false.png b/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_boolean_equals_false.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:8ae2beab7485970d5ec8ae0431e16e5d5a358b92f6862d2eedddee79eacdfa01
-size 15545
+oid sha256:88ae8b64f7554962718a36fa7d8788459fbf477d8cf9ee85f9e15ce39d6f2c45
+size 15637
diff --git a/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_boolean_equals_true.png b/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_boolean_equals_true.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:3d09d979e777b1c8da955cd6c4d058dfd919c2657b5b3162de8833d1ade68a07
-size 15550
+oid sha256:9b728a2ac97e151400a4b0ea9839011a02e42333290dac7ba7941bc8a87381e8
+size 15643
diff --git a/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_float_compares.png b/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_float_compares.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:5e2aa3a4b3e0355d8b3d3571f254b99c4ce0206d1005ee410c162d3290f87679
-size 14899
+oid sha256:4673e3f1c11167454b647c33bd7904069dc6e2c4bddb481f6ffafd8f30fdedae
+size 14917
diff --git a/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_float_compares_none.png b/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_float_compares_none.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:7babe026537a94f527b174958ccd6f833e2b1e276f9b35ab362973c9f66b3db8
-size 14297
+oid sha256:5e5269d172e8fa009a0ebbeb5510b0919de219ec1eb4e65a407ba8900c90c650
+size 14316
diff --git a/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_int_compare.png b/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_int_compare.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:1a5c790f1fccc4c90b01a58c3c02f4b4b9ed2cee239b9f4d1ee77d16458dbfe4
-size 14788
+oid sha256:d842d28237445584ad27d9c61892f1a88d18b9ededb20fcf65d08e2f5a7f09de
+size 14835
diff --git a/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_int_compare_none.png b/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_int_compare_none.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:9133f6f11a63bd7eedd5dc1f473f985aab7e8565d88b11979620f42cb4ee8149
-size 14248
+oid sha256:65ca5cf3a2d92660830ce535d656501503c13e60c99c683065354486b250bfca
+size 14249
diff --git a/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_nullable_boolean_equals_false.png b/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_nullable_boolean_equals_false.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:2dbbdf4141f35f6b9875249a5b73221374a87e5fc0e944f0a347c558b2500efc
-size 16155
+oid sha256:0ed35bc49c5790d9feec1120421ffdfd219e8b31dc94b9f8f0fca5127b2cd5e7
+size 16275
diff --git a/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_nullable_boolean_equals_null.png b/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_nullable_boolean_equals_null.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:4854754af34624473e4bba3689a84bdca28005a3cf1634b8b0cf2fdd394ee7fe
-size 16143
+oid sha256:73e62a1375b5fe86286e928200cecf75b31edd4515982d6b88c4fa28665ed8f3
+size 16274
diff --git a/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_nullable_boolean_equals_true.png b/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_nullable_boolean_equals_true.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:3ed5fee7850a1d93f8dfd2c3c981bf57655efb78a26ac3c16d8b844fe1979443
-size 16160
+oid sha256:fda0f993239eb1cf4ad488ad71ea77d689ac896cbff53ec0567615412e0b061a
+size 16280
diff --git a/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_string_contains.png b/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_string_contains.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:3f2a5549bd2822953f6b3d3d7014fcee2ef024deb48653cd6c7b3803cb94b4d9
-size 15901
+oid sha256:d8abac8ec7cd5afd062933baf069956a912e99d861f5953cd22a772ca954d50a
+size 15913
diff --git a/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_string_contains_empty.png b/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_string_contains_empty.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:883ad42a3402ef85241fd9b8ea5a61fe2897dfea85354cf09d59e1b28307cbe2
-size 15095
+oid sha256:9fd0dccfbfa2c69cf5eaa0702712e637ba076ecf13c1e59574486289c8fa53c4
+size 15107
diff --git a/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_string_starts_with.png b/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_string_starts_with.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:ab9cfb56219e1a698dafa6c5fb28c073aaae9573c073741acc49e8dd14bca0c2
-size 16240
+oid sha256:08a942d9e6e514a58dd442e10f4c7bc8bcb0ee1e96462f9867cfe8af97af14f8
+size 16255
diff --git a/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_timestamp_after.png b/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_timestamp_after.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:a454792bf823ebeec4b3ff861189db13fb023cb1b4cd82f28bd987ca88011aee
-size 33233
+oid sha256:0c3213f2a9c6fc8087c1869fcf4d09eacf3962d885e2da91bbb0e4f78397915c
+size 33524
diff --git a/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_timestamp_between.png b/crates/viewer/re_dataframe_ui/tests/snapshots/popup_ui_timestamp_between.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:617c061c761a2c8cc40275774b7ee81bcd72d70a8ca7478813ed6ab43758fbfb
-size 40483
+oid sha256:79bf0dd3b5b0b1d6d8a2fe2957f46d528747ac9ff6d2b4b65b12ad4df7c717fe
+size 40835
diff --git a/crates/viewer/re_ui/data/dark_theme.ron b/crates/viewer/re_ui/data/dark_theme.ron
@@ -158,7 +158,7 @@
     },
 
     "floating_color": {
-      "color": "{Gray.250}"
+      "color": "{Gray.200}"
     },
     "faint_bg_color": {
       "color": "{Gray.150}"
diff --git a/crates/viewer/re_ui/tests/snapshots/help_Mac.png b/crates/viewer/re_ui/tests/snapshots/help_Mac.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:2d06f4c0f27caf9f67f3a144fc0affde923477f4cb0f167f49cbb054713c51bf
-size 44665
+oid sha256:08c13cdb142ea36c38ec852c7fab819164f97a1c3b8e0c8f111034d656cae96b
+size 44854
diff --git a/crates/viewer/re_ui/tests/snapshots/help_Windows.png b/crates/viewer/re_ui/tests/snapshots/help_Windows.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:43c6853dbec385ec1b2e51d6a02c2265d373aaa1df772e3238c6d81203689365
-size 45400
+oid sha256:87b279069eed90cf52ff9b02fda22156559f3895b160b723c8bf8861291135d7
+size 45567
diff --git a/crates/viewer/re_view_spatial/tests/annotations.rs b/crates/viewer/re_view_spatial/tests/annotations.rs
@@ -99,7 +99,10 @@ fn run_view_ui_and_save_snapshot(
 
         let name = format!("{name}_overview");
         harness.run();
-        harness.snapshot(&name);
+        harness.snapshot_options(
+            &name,
+            &SnapshotOptions::new().failed_pixel_count_threshold(1),
+        );
     }
 
     {
@@ -117,7 +120,10 @@ fn run_view_ui_and_save_snapshot(
                 .events
                 .push(egui::Event::PointerMoved((50.0, 200.0).into()));
             harness.try_run_realtime().ok();
-            harness.snapshot(&name);
+            harness.snapshot_options(
+                &name,
+                &SnapshotOptions::new().failed_pixel_count_threshold(1),
+            );
         }
 
         {
@@ -127,7 +133,10 @@ fn run_view_ui_and_save_snapshot(
                 .events
                 .push(egui::Event::PointerMoved((200.0, 250.0).into()));
             harness.run();
-            harness.snapshot(&name);
+            harness.snapshot_options(
+                &name,
+                &SnapshotOptions::new().failed_pixel_count_threshold(1),
+            );
         }
 
         {
@@ -137,7 +146,10 @@ fn run_view_ui_and_save_snapshot(
                 .events
                 .push(egui::Event::PointerMoved((300.0, 400.0).into()));
             harness.run();
-            harness.snapshot(&name);
+            harness.snapshot_options(
+                &name,
+                &SnapshotOptions::new().failed_pixel_count_threshold(1),
+            );
         }
 
         {
@@ -161,7 +173,10 @@ fn run_view_ui_and_save_snapshot(
                 .events
                 .push(egui::Event::PointerMoved((425., 275.0).into()));
             harness.run();
-            harness.snapshot(&name);
+            harness.snapshot_options(
+                &name,
+                &SnapshotOptions::new().failed_pixel_count_threshold(1),
+            );
         }
     }
 }
diff --git a/crates/viewer/re_view_spatial/tests/snapshots/annotations_hover_background.png b/crates/viewer/re_view_spatial/tests/snapshots/annotations_hover_background.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:034667872998f6bd51ed1b0ae0554d890b4e947305bcf09f1734164066ad45b1
-size 20333
+oid sha256:cc889c5dc6cab01e3991270f2963a19ede055d3d3b48b8de6128cc3d37b01ad9
+size 20433
diff --git a/crates/viewer/re_view_spatial/tests/snapshots/annotations_hover_rect_green.png b/crates/viewer/re_view_spatial/tests/snapshots/annotations_hover_rect_green.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:6079c134f1e84e00bc14443ea6acc64e553e2cc5890938988cd7bb0c11f3b53c
-size 20386
+oid sha256:e753a64d8a0b52ee64e2b771bf8d6c9aebec42a6c4796812c617df11a874923c
+size 20448
diff --git a/crates/viewer/re_view_spatial/tests/snapshots/annotations_hover_rect_red.png b/crates/viewer/re_view_spatial/tests/snapshots/annotations_hover_rect_red.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:738845f070f57f1c5aba3738dfd14d5793284eab0cbbf00f7419cbb40aee1763
-size 21088
+oid sha256:0d90d57adf19ed49d743a0df4f7e4c4e06609d873c5bd79ba41df1a22089e659
+size 21138
diff --git a/crates/viewer/re_view_spatial/tests/snapshots/annotations_hover_region_green.png b/crates/viewer/re_view_spatial/tests/snapshots/annotations_hover_region_green.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:4883cae3d92620673d140ced325325fb1f35b66a55423198e1dd770154a0ab28
-size 34529
+oid sha256:147b2aa9ae62776e7c14c1e787a464ad1d5d5877992fe00bd41485de6cb9f82b
+size 34662
diff --git a/crates/viewer/re_view_spatial/tests/snapshots/annotations_hover_region_red.png b/crates/viewer/re_view_spatial/tests/snapshots/annotations_hover_region_red.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:6a753d329553e93fe7c60ceb7d9aeb012d555c0473858559f9d6a09ff1f1aedd
-size 32354
+oid sha256:84d0a61afb35d66eb81f2db9f31afcd55d3f73c220ea7d24c6f60c8ecede7319
+size 32609
diff --git a/crates/viewer/re_viewer/tests/snapshots/colormap_selector_open.png b/crates/viewer/re_viewer/tests/snapshots/colormap_selector_open.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:d24942adb32179b65f258e83169bff4fb87c0e22057ecc0cab0ffb8f70f82315
-size 17631
+oid sha256:a00530256f06574da33bdbb8f306c5ff6f1a0d318ef56b61206d16a20fe4498c
+size 17759
