Add arrow DisplayOptions and make limits configurable (#11139)

Co-authored-by: Emil Ernerfeldt <[email protected]>
Co-authored-by: Jochen Görtler <[email protected]>

Author: 3 people

Cargo.lock

@@ -7219,6 +7219,7 @@ dependencies = [
  "arrow",
  "egui",
  "egui_kittest",
+ "insta",
  "re_arrow_util",
  "re_format",
  "re_tracing",

crates/viewer/re_arrow_ui/Cargo.toml

@@ -25,5 +25,7 @@ arrow.workspace = true
 egui.workspace = true
 
 [dev-dependencies]
-egui_kittest.workspace = true
 re_types.workspace = true
+
+egui_kittest.workspace = true
+insta.workspace = true

crates/viewer/re_arrow_ui/src/arrow_ui.rs

@@ -1,9 +1,9 @@
-use arrow::{array::Array, error::ArrowError, util::display::FormatOptions};
+use arrow::{array::Array, error::ArrowError};
 use re_ui::list_item::list_item_scope;
 use re_ui::{UiExt as _, UiLayout};
 
 use crate::datatype_ui::DataTypeUi;
-use crate::show_index::ArrayUi;
+use crate::show_index::{ArrayUi, DisplayOptions};
 
 pub fn arrow_ui(ui: &mut egui::Ui, ui_layout: UiLayout, array: &dyn Array) {
     re_tracing::profile_function!();
@@ -51,9 +51,6 @@ pub fn arrow_ui(ui: &mut egui::Ui, ui_layout: UiLayout, array: &dyn Array) {
 }
 
 pub(crate) fn make_ui(array: &dyn Array) -> Result<ArrayUi<'_>, ArrowError> {
-    let options = FormatOptions::default()
-        .with_null("null")
-        .with_display_error(true);
-    let array_ui = ArrayUi::try_new(array, &options)?;
+    let array_ui = ArrayUi::try_new(array, &DisplayOptions::default())?;
     Ok(array_ui)
 }

crates/viewer/re_arrow_ui/src/lib.rs

@@ -6,3 +6,9 @@ mod list_item_ranges;
 mod show_index;
 
 pub use arrow_ui::arrow_ui;
+
+pub fn arrow_syntax_highlighted(
+    data: &dyn arrow::array::Array,
+) -> Result<re_ui::syntax_highlighting::SyntaxHighlightedBuilder, arrow::error::ArrowError> {
+    show_index::ArrayUi::try_new(data, &show_index::DisplayOptions::default())?.highlighted()
+}