Skip to content

Commit e007e07

Browse files
authored
StreamDecoder: fix support for out-of-order legacy store ID (#11455)
This PR ports the test suite from the legacy `Decoder` to the new `StreamDecoder`, to ensure they are fully compatible. In doing so, I stumbled upon a bug where the `StreamDecoder` would enter an obscure irrecoverable state when faced with an out-of-order legacy store ID (i.e. a store ID missing an app ID). This PR fixes that. Also removed some duplicated code on the way. --- This PR is part of an upcoming series of PRs to pay off organic growth debt in our encoding/decoding stack. * DNM: requires #11452
1 parent f229f8e commit e007e07

File tree

2 files changed

+368
-4
lines changed

2 files changed

+368
-4
lines changed

crates/store/re_log_encoding/src/codec/file/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ impl MessageKind {
2323
}
2424

2525
#[allow(dead_code)] // used behind feature flag
26-
#[derive(Debug, Clone, Copy)]
26+
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
2727
pub(crate) struct MessageHeader {
2828
pub(crate) kind: MessageKind,
2929
pub(crate) len: u64,

0 commit comments

Comments
 (0)