feedback

Author: grtlr

Cargo.lock

@@ -5704,8 +5704,6 @@ version = "0.26.0-alpha.1+dev"
 dependencies = [
  "anyhow",
  "arrow",
- "clap",
- "insta",
  "rerun",
 ]
 

crates/top/re_sdk/src/lenses.rs

@@ -121,6 +121,7 @@ mod op {
     use super::Error;
 
     /// Extracts a specific field from a struct component within a `ListArray`.
+    #[derive(Debug)]
     pub struct AccessField {
         pub(super) field_name: String,
     }
@@ -157,6 +158,7 @@ mod op {
     }
 
     /// Casts the `value_type` (inner array) of a `ListArray` to a different data type.
+    #[derive(Debug)]
     pub struct Cast {
         pub(super) to_inner_type: DataType,
     }
@@ -215,6 +217,16 @@ pub enum Op {
     Func(Box<dyn Fn(ListArray) -> Result<ListArray, Error> + Sync + Send>),
 }
 
+impl std::fmt::Debug for Op {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        match self {
+            Self::AccessField(inner) => f.debug_tuple("AccessField").field(inner).finish(),
+            Self::Cast(inner) => f.debug_tuple("Cast").field(inner).finish(),
+            Self::Func(_) => f.debug_tuple("Func").field(&"<function>").finish(),
+        }
+    }
+}
+
 impl Op {
     /// Extracts a specific field from a `StructArray`.
     pub fn access_field(field_name: impl Into<String>) -> Self {
@@ -378,12 +390,19 @@ impl Lens {
 
             let mut list_array_result = list_array.clone();
             for op in &output.ops {
-                if let Ok(result) = op.call(list_array_result) {
-                    list_array_result = result;
-                } else {
-                    // TODO: context!
-                    re_log::error!("failed");
-                    return vec![];
+                match op.call(list_array_result) {
+                    Ok(result) => {
+                        list_array_result = result;
+                    }
+                    Err(err) => {
+                        re_log::error!(
+                            "Lens operation '{:?}' failed for output column '{}' on entity '{}': {err}",
+                            op,
+                            output.entity_path,
+                            output.component_descr.component
+                        );
+                        return vec![];
+                    }
                 }
             }
 
@@ -399,7 +418,7 @@ impl Lens {
                     chunk.timelines().clone()
                 };
 
-                // TODO: In case of static, should we use sparse rows instead?
+                // TODO(grtlr): In case of static, should we use sparse rows instead?
                 Chunk::from_auto_row_ids(ChunkId::new(), entity_path.clone(), timelines, components)
                     .inspect_err(|err| {
                         re_log::error_once!(

examples/manifest.toml

@@ -152,6 +152,7 @@ examples = [
   "graphs",
   "camera_video_stream",
   "log_file",
+  "lenses",
   "openstreetmap_data",
   "minimal",
   "multiprocess_logging",

examples/rust/lenses/Cargo.toml

@@ -14,7 +14,3 @@ rerun = { path = "../../../crates/top/rerun", features = [
 
 anyhow.workspace = true
 arrow.workspace = true
-clap = { workspace = true, features = ["derive"] }
-
-[dev-dependencies]
-insta.workspace = true

examples/rust/lenses/README.md

@@ -1,10 +1,9 @@
 <!--[metadata]
-title = "Transform recording stream example"
+title = "Lenses example"
+channel = "main"
 -->
 
-<!-- TODO: -->
-
-Demonstrates how to transform log messages before forwarding them to the sink the SDK.
+Demonstrates how to use lenses to transform log messages before forwarding them to an underlying sink.
 ```bash
 cargo run -p lenses
 ```