Skip to content

Commit ebdc072

Browse files
authored
Enable the same datafusion features everywhere (#11385)
1 parent 675616d commit ebdc072

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

Cargo.toml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,17 @@ criterion = "0.5"
222222
cros-codecs = "0.0.6"
223223
crossbeam = "0.8"
224224
datafusion = { version = "49.0.2", default-features = false, features = [
225+
# NOTE: we enable the same features everywhere
226+
# because otherwise we will recompile datafusion all the time based on our current compile target.
227+
# The features here are the same as in https://github.com/lancedb/lance/blob/v0.36.0/Cargo.toml#L99-L107
228+
# This is very hacky, and I don't like it.
229+
"crypto_expressions",
230+
"datetime_expressions",
231+
"encoding_expressions",
225232
"nested_expressions",
233+
"regex_expressions",
234+
"string_expressions",
235+
"unicode_expressions",
226236
] }
227237
datafusion-ffi = "49.0.2"
228238
directories = "6"
@@ -257,7 +267,7 @@ itertools = "0.14"
257267
jiff = { version = "0.2.3", features = ["js"] }
258268
js-sys = "0.3"
259269
jsonwebtoken = { version = "9", default-features = false }
260-
lance = { version = "0.36.0", default-features = false }
270+
lance = { version = "0.36.0", default-features = false } # When you update this, also update the list of features enabled for `datafusion` (~50 lines up)
261271
libc = "0.2"
262272
linked-hash-map = { version = "0.5", default-features = false }
263273
log = "0.4"

0 commit comments

Comments
 (0)