do remaining todos

Author: IsseW

crates/viewer/re_global_context/src/command_sender.rs

@@ -110,11 +110,8 @@ pub enum SystemCommand {
     /// Set the active timeline and time for the given recording.
     SetActiveTime {
         store_id: StoreId,
-        timeline: re_chunk::Timeline,
-        time: Option<re_log_types::TimeReal>,
-
-        /// If this is true the timeline will persist even if it is invalid at the moment.
-        pending: bool,
+        timeline: re_chunk::TimelineName,
+        time: Option<re_log_types::TimeInt>,
     },
 
     /// Set the loop selection for the given timeline.

crates/viewer/re_test_context/src/lib.rs

@@ -595,9 +595,8 @@ impl TestContext {
             self.command_sender
                 .send_system(SystemCommand::SetActiveTime {
                     store_id,
-                    timeline: re_chunk::Timeline::new(timeline, timecell.typ()),
-                    time: Some(timecell.as_i64().into()),
-                    pending: true,
+                    timeline,
+                    time: Some(timecell.value.into()),
                 });
         }
     }
@@ -652,17 +651,16 @@ impl TestContext {
                     store_id: rec_id,
                     timeline,
                     time,
-                    pending: _,
                 } => {
                     assert_eq!(
                         &rec_id,
                         self.store_hub.lock().active_recording().unwrap().store_id()
                     );
                     self.with_blueprint_ctx(|ctx| {
-                        ctx.set_timeline(*timeline.name());
+                        ctx.set_timeline(timeline);
 
                         if let Some(time) = time {
-                            ctx.set_time(time.floor());
+                            ctx.set_time(time);
                         }
                     });
                 }

crates/viewer/re_view_dataframe/src/dataframe_ui.rs

@@ -375,9 +375,8 @@ impl egui_table::TableDelegate for DataframeTableDelegate<'_> {
                                 self.ctx.command_sender().send_system(
                                     re_viewer_context::SystemCommand::SetActiveTime {
                                         store_id: self.ctx.store_id().clone(),
-                                        timeline: descr.timeline(),
+                                        timeline: *descr.timeline().name(),
                                         time: None,
-                                        pending: false,
                                     },
                                 );
                             }

crates/viewer/re_viewer/src/app.rs

@@ -912,20 +912,16 @@ impl App {
 
             SystemCommand::SetActiveTime {
                 store_id,
-                // TODO: Make this only be timeline name.
                 timeline,
-                // TODO: Make this be time int?
                 time,
-                // TODO: Remove this
-                pending: _,
             } => {
                 if let Some(blueprint_ctx) =
                     blueprint_ctx(&mut self.state, &self.command_sender, store_hub)
                 {
-                    blueprint_ctx.set_timeline(*timeline.name());
+                    blueprint_ctx.set_timeline(timeline);
 
                     if let Some(time) = time {
-                        blueprint_ctx.set_time(time.floor());
+                        blueprint_ctx.set_time(time);
                     }
 
                     if let Some(rec_cfg) = self.recording_config_mut(store_hub, &store_id) {
@@ -1157,9 +1153,8 @@ impl App {
             self.command_sender
                 .send_system(SystemCommand::SetActiveTime {
                     store_id,
-                    timeline: re_chunk::Timeline::new(timeline, timecell.typ()),
-                    time: Some(timecell.as_i64().into()),
-                    pending: true,
+                    timeline: timeline,
+                    time: Some(timecell.value.into()),
                 });
         }
     }