From 8090a887a7e3878d10c9a6265cbf30cfc427b2db Mon Sep 17 00:00:00 2001 From: lucasmerlin Date: Fri, 19 Sep 2025 14:47:00 +0200 Subject: [PATCH 1/4] Add kitdiff comment --- .github/workflows/reusable_build_web.yml | 4 ++++ .github/workflows/reusable_upload_web.yml | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/.github/workflows/reusable_build_web.yml b/.github/workflows/reusable_build_web.yml index b2c4e84c9df7..45cd612b21b7 100644 --- a/.github/workflows/reusable_build_web.yml +++ b/.github/workflows/reusable_build_web.yml @@ -71,6 +71,8 @@ jobs: | ------ | ------- | ----- | -------- | | ⏳ | ${{ steps.get-sha.outputs.sha }} | https://rerun.io/viewer/pr/${{ github.event.pull_request.number }} | [`+nightly`](https://rerun.io/viewer/pr/${{ github.event.pull_request.number }}?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) [`+main`](https://rerun.io/viewer/pr/${{ github.event.pull_request.number }}?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) | + View image diff on [https://rerun-io.github.io/kitdiff/?url=${{github.event.pull_request.html_url}}](kitdiff). + Note: This comment is updated whenever you push a commit. - name: Set up Rust @@ -125,4 +127,6 @@ jobs: | ------ | ------- | ----- | -------- | | ❌ | ${{ steps.get-sha.outputs.sha }} | https://rerun.io/viewer/pr/${{ github.event.pull_request.number }} | [`+nightly`](https://rerun.io/viewer/pr/${{ github.event.pull_request.number }}?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) [`+main`](https://rerun.io/viewer/pr/${{ github.event.pull_request.number }}?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) | + View image diff on [https://rerun-io.github.io/kitdiff/?url=${{github.event.pull_request.html_url}}](kitdiff). + Note: This comment is updated whenever you push a commit. diff --git a/.github/workflows/reusable_upload_web.yml b/.github/workflows/reusable_upload_web.yml index 5bb65f122289..1a5d7c045ed7 100644 --- a/.github/workflows/reusable_upload_web.yml +++ b/.github/workflows/reusable_upload_web.yml @@ -153,6 +153,8 @@ jobs: | ------ | ------- | ---- | -------- | | ✅ | ${{ steps.get-sha.outputs.sha }} | https://rerun.io/viewer/pr/${{ github.event.pull_request.number }} | [`+nightly`](https://rerun.io/viewer/pr/${{ github.event.pull_request.number }}?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) [`+main`](https://rerun.io/viewer/pr/${{ github.event.pull_request.number }}?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) | + View image diff on [https://rerun-io.github.io/kitdiff/?url=${{github.event.pull_request.html_url}}](kitdiff). + Note: This comment is updated whenever you push a commit. - name: Status comment @@ -169,4 +171,6 @@ jobs: | ------ | ------- | ----- | | ❌ | ${{ steps.get-sha.outputs.sha }} | https://rerun.io/viewer/pr/${{ github.event.pull_request.number }} | [`+nightly`](https://rerun.io/viewer/pr/${{ github.event.pull_request.number }}?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) [`+main`](https://rerun.io/viewer/pr/${{ github.event.pull_request.number }}?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) | + View image diff on [https://rerun-io.github.io/kitdiff/?url=${{github.event.pull_request.html_url}}](kitdiff). + Note: This comment is updated whenever you push a commit. From 8366d82a8ddc0590ed27d9850d3323c5937d6a55 Mon Sep 17 00:00:00 2001 From: lucasmerlin Date: Fri, 19 Sep 2025 14:48:11 +0200 Subject: [PATCH 2/4] Some random color changes for effect --- crates/viewer/re_ui/data/dark_theme.ron | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/viewer/re_ui/data/dark_theme.ron b/crates/viewer/re_ui/data/dark_theme.ron index a1de2ce40833..9fd52aec8395 100644 --- a/crates/viewer/re_ui/data/dark_theme.ron +++ b/crates/viewer/re_ui/data/dark_theme.ron @@ -95,7 +95,7 @@ }, "panel_bg_color": { - "color": "{Gray.100}" + "color": "{Red.100}" }, "text_edit_bg_color": { "color": "{Gray.200}" @@ -203,10 +203,10 @@ "color": "{Gray.550}" }, "text_default": { - "color": "{Gray.775}" + "color": "{Gray.355}" }, "text_strong": { - "color": "{Gray.1000}" + "color": "{Green.1000}" }, "error_fg_color": { "color": "#AB0116" From 46ea4834afaa8b9e5b4a1d4c4c9303287a4e4c48 Mon Sep 17 00:00:00 2001 From: lucasmerlin Date: Fri, 19 Sep 2025 14:50:23 +0200 Subject: [PATCH 3/4] Fix order --- .github/workflows/reusable_build_web.yml | 4 ++-- .github/workflows/reusable_upload_web.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/reusable_build_web.yml b/.github/workflows/reusable_build_web.yml index 45cd612b21b7..9a0eaab273db 100644 --- a/.github/workflows/reusable_build_web.yml +++ b/.github/workflows/reusable_build_web.yml @@ -71,7 +71,7 @@ jobs: | ------ | ------- | ----- | -------- | | ⏳ | ${{ steps.get-sha.outputs.sha }} | https://rerun.io/viewer/pr/${{ github.event.pull_request.number }} | [`+nightly`](https://rerun.io/viewer/pr/${{ github.event.pull_request.number }}?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) [`+main`](https://rerun.io/viewer/pr/${{ github.event.pull_request.number }}?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) | - View image diff on [https://rerun-io.github.io/kitdiff/?url=${{github.event.pull_request.html_url}}](kitdiff). + View image diff on [kitdiff](https://rerun-io.github.io/kitdiff/?url=${{github.event.pull_request.html_url}}). Note: This comment is updated whenever you push a commit. @@ -127,6 +127,6 @@ jobs: | ------ | ------- | ----- | -------- | | ❌ | ${{ steps.get-sha.outputs.sha }} | https://rerun.io/viewer/pr/${{ github.event.pull_request.number }} | [`+nightly`](https://rerun.io/viewer/pr/${{ github.event.pull_request.number }}?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) [`+main`](https://rerun.io/viewer/pr/${{ github.event.pull_request.number }}?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) | - View image diff on [https://rerun-io.github.io/kitdiff/?url=${{github.event.pull_request.html_url}}](kitdiff). + View image diff on [kitdiff](https://rerun-io.github.io/kitdiff/?url=${{github.event.pull_request.html_url}}). Note: This comment is updated whenever you push a commit. diff --git a/.github/workflows/reusable_upload_web.yml b/.github/workflows/reusable_upload_web.yml index 1a5d7c045ed7..a3e3e5264b75 100644 --- a/.github/workflows/reusable_upload_web.yml +++ b/.github/workflows/reusable_upload_web.yml @@ -153,7 +153,7 @@ jobs: | ------ | ------- | ---- | -------- | | ✅ | ${{ steps.get-sha.outputs.sha }} | https://rerun.io/viewer/pr/${{ github.event.pull_request.number }} | [`+nightly`](https://rerun.io/viewer/pr/${{ github.event.pull_request.number }}?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) [`+main`](https://rerun.io/viewer/pr/${{ github.event.pull_request.number }}?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) | - View image diff on [https://rerun-io.github.io/kitdiff/?url=${{github.event.pull_request.html_url}}](kitdiff). + View image diff on [kitdiff](https://rerun-io.github.io/kitdiff/?url=${{github.event.pull_request.html_url}}). Note: This comment is updated whenever you push a commit. @@ -171,6 +171,6 @@ jobs: | ------ | ------- | ----- | | ❌ | ${{ steps.get-sha.outputs.sha }} | https://rerun.io/viewer/pr/${{ github.event.pull_request.number }} | [`+nightly`](https://rerun.io/viewer/pr/${{ github.event.pull_request.number }}?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) [`+main`](https://rerun.io/viewer/pr/${{ github.event.pull_request.number }}?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) | - View image diff on [https://rerun-io.github.io/kitdiff/?url=${{github.event.pull_request.html_url}}](kitdiff). + View image diff on [kitdiff](https://rerun-io.github.io/kitdiff/?url=${{github.event.pull_request.html_url}}). Note: This comment is updated whenever you push a commit. From 0bf33a0d48842c3d6dd82b00e6b4fb4383e54ec3 Mon Sep 17 00:00:00 2001 From: lucasmerlin Date: Mon, 22 Sep 2025 17:49:18 +0200 Subject: [PATCH 4/4] Make invalid wrong color valid wrong color --- crates/viewer/re_ui/data/dark_theme.ron | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/viewer/re_ui/data/dark_theme.ron b/crates/viewer/re_ui/data/dark_theme.ron index 9fd52aec8395..9815fb619d82 100644 --- a/crates/viewer/re_ui/data/dark_theme.ron +++ b/crates/viewer/re_ui/data/dark_theme.ron @@ -203,7 +203,7 @@ "color": "{Gray.550}" }, "text_default": { - "color": "{Gray.355}" + "color": "{Gray.350}" }, "text_strong": { "color": "{Green.1000}"