Skip to content

feat(ci): dynamically assign port and catalog URL in test setup #11393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(ci): dynamically assign port and catalog URL in test setup #11393

wants to merge 3 commits into from
+14 −10

Conversation

Weijun-H
Copy link
Contributor

@Weijun-H Weijun-H commented Oct 1, 2025

Related

Closes #11173

What

dynamically assign port and catalog URL in test setup

@Weijun-H Weijun-H force-pushed the 11173-free-port-on-ci branch from 4d69825 to fe8ede1 Compare October 1, 2025 12:03
Wumpf
Wumpf requested changes Oct 7, 2025
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dataflow with the global starting out its live as None is very unclear in here now. Better to pass it own
Also there's no reason for CATALOG_URL being global

@Weijun-H Weijun-H force-pushed the 11173-free-port-on-ci branch from 6a68a2e to 13f7b40 Compare October 7, 2025 08:52
@Weijun-H Weijun-H requested a review from Wumpf October 7, 2025 18:10
Wumpf
Wumpf approved these changes Oct 8, 2025
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Wumpf Wumpf added 🔨 testing testing and benchmarks exclude from changelog PRs with this won't show up in CHANGELOG.md labels Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🔨 testing testing and benchmarks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pick any free port in our tests
2 participants
@Weijun-H @Wumpf