Updating Rust deps to their latest version #11990
Conversation
emilk
left a comment
emilk
left a comment
There was a problem hiding this comment.
You need to commit a new Cargo.lock too
| js-sys = "0.3.77" | ||
| jsonwebtoken = { version = "9.3", default-features = false } | ||
| lance = { version = "0.38.2", default-features = false } # When you update this, also update the list of features enabled for `datafusion` (~50 lines up) | ||
| lance = { version = "0.39.0", default-features = false } # When you update this, also update the list of features enabled for `datafusion` (~50 lines up) |
There was a problem hiding this comment.
did you remember to follow this instruction?
There was a problem hiding this comment.
@emilk Added cargo.lock and there is no difference b/w the datafusion feature set in v0.39.0 and v0.38.0
v0.39.0 -> https://github.com/lance-format/lance/blob/ab5fdb362eda381bab5cb559cee94de8b3d63c6d/Cargo.toml#L106
v0.38.0 -> https://github.com/lance-format/lance/blob/v0.38.0/Cargo.toml#L99-L107
There was a problem hiding this comment.
The Lance datafusion update isn't ready yet, so no surprise on these updates to the lock.
emilk
added
dependencies
|
Looks like a lot of crates no longer compile. Please make sure |
| js-sys = "0.3.77" | ||
| jsonwebtoken = { version = "9.3", default-features = false } | ||
| lance = { version = "0.38.2", default-features = false } # When you update this, also update the list of features enabled for `datafusion` (~50 lines up) | ||
| lance = { version = "0.39.0", default-features = false } # When you update this, also update the list of features enabled for `datafusion` (~50 lines up) |
There was a problem hiding this comment.
@timsaucer is there any reason not to update lance right now?
There was a problem hiding this comment.
I don't see any blocker here, but we would want to update our platform repo in lock step.
|
@emilk I have reverted a lot of deps back to their previous version or to a different version because there were lot of conflicts in crates. the command 
|
|
@emilk All the checks seems to be passing now in CI/CD , is there anything else you want me to validate ? |
3 participants
Part of #11467
Updated some of the core dependencies to their latest version.
I have tested the change by running rerun as both desktop and web application. The examples are working fine.
@Wumpf @emilk Please take a look at the PR when you have time and let me know if any other validation is also required.