Load pinhole in mcap_protobuf example
#12035
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelGrupp
added
exclude from changelog
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
MichaelGrupp
commented
Dec 2, 2025
| .build(); | ||
|
|
||
| // Simple pinhole camera calibration lens, setting `image_from_camera` from the `K` matrix. | ||
| // TODO(michael): set child_frame of Pinhole? |
Member
Author
There was a problem hiding this comment.
Hardcode (just for the example)?
MichaelGrupp
force-pushed
the
michael/row-to-col-major-combinator
branch
from
7cfd4d0 to
35ebb00
Compare
MichaelGrupp
force-pushed
the
michael/mcap-protobuf-camera-calibration
branch
from
bc25c40 to
a5955f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://linear.app/rerun/issue/RR-2327
Requires the combinators from: #12031