Skip to content

Conversation

@timsaucer
Copy link
Member

@timsaucer timsaucer commented Dec 1, 2025

This PR add unit tests for tables and datasets to be accessed via S3.

Leaving as draft until all combinations have been covered for s3:

  • creating tables
  • reading tables
  • writing tables
  • registering tables
  • reading datasets
  • registering datasets
  • creating datasets

The first test did work manually with this command:

pixi run -e py pytest rerun_py/tests/e2e_redap_tests/test_table_create.py -k test_create_table_on_s3 -m aws_ci_credentials --resource-prefix 's3://dogfooding-test-remove/test' --redap-url 'rerun+http://localhost:51234'

Also we still need to figure out how to ensure two tests running concurrently do not step on each other.

@timsaucer timsaucer added the do-not-merge Do not merge this PR label Dec 1, 2025
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Latest documentation preview deployed successfully.

Result Commit Link
73494d3 https://landing-93wrfhiyb-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Web viewer built successfully.

Result Commit Link Manifest
73494d3 https://rerun.io/viewer/pr/12036 +nightly +main

View image diff on kitdiff.

Note: This comment is updated whenever you push a commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge Do not merge this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants