Add e2e test for creating a table that already exists #12037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timsaucer
added
🔨 testing
abey79
approved these changes
Dec 2, 2025
| assert returned_field.metadata == original_field.metadata | ||
|
|
||
|
|
||
| def test_create_existing_table_fails( |
Member
There was a problem hiding this comment.
iirc you're going to have to mark this one as creates_table, otherwise it'll break DPF ci.
Member
Author
There was a problem hiding this comment.
Really? It doesn't actually create any tables.
|
|
||
|
|
||
| def test_create_existing_table_fails( | ||
| prefilled_catalog: PrefilledCatalog, entry_factory: EntryFactory, tmp_path: pathlib.Path |
Member
There was a problem hiding this comment.
prefilled_catalog already contains an EntryFactory, so you can use prefilled_catalog.factory instead of having the explicit fixture.
Also, not necessary for this PR, but EntryFactory could have introspection APIs to list entries created so far. Could be occasionally convenient, eg when you want to trigger a collision like in this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we attempt to create a table in the server that already exists, either by table name or location, we should fail.