Partition-to-segment rename (wave 2): re_uri
#12050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abey79
added
📺 re_viewer
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
abey79
commented
Dec 2, 2025
Comment on lines
57
to
107
| pub fn new(origin: Origin, dataset_id: re_tuid::Tuid, url: &url::Url) -> Result<Self, Error> { | ||
| let mut partition_id = None; | ||
| let mut segment_id = None; | ||
| let mut legacy_partition_id = None; | ||
| let mut time_range = None; | ||
|
|
||
| for (key, value) in url.query_pairs() { | ||
| match key.as_ref() { | ||
| // Accept legacy `partition_id` query parameter. | ||
| "partition_id" => { | ||
| partition_id = Some(value.to_string()); | ||
| legacy_partition_id = Some(value.to_string()); | ||
| } | ||
|
|
||
| "segment_id" => { | ||
| segment_id = Some(value.to_string()); | ||
| } | ||
| "time_range" => { | ||
| // `+` means whitespace in URLs. | ||
| // Ideally `+` should be encoded as `%2B`, but in case we missed that: | ||
| let value = value.replace(' ', ""); | ||
| time_range = Some(value.parse::<TimeSelection>()?); | ||
| } | ||
| _ => { | ||
| // We ignore unknown query keys that may be from urls from prior/newer versions. | ||
| } | ||
| } | ||
| } | ||
|
|
||
| let Some(partition_id) = partition_id else { | ||
| return Err(Error::MissingPartitionId); | ||
| let segment_id = match (segment_id, legacy_partition_id) { | ||
| (Some(s), None) | (None, Some(s)) => s, | ||
|
|
||
| (None, None) => { | ||
| return Err(Error::MissingSegmentId); | ||
| } | ||
|
|
||
| (Some(_), Some(_)) => { | ||
| return Err(Error::AmbiguousSegmentId); | ||
| } | ||
| }; | ||
|
|
||
| let mut fragment = Fragment::default(); | ||
| if let Some(string) = url.fragment() { | ||
| fragment = Fragment::parse_forgiving(string); | ||
| } | ||
|
|
||
| Ok(Self { | ||
| origin, | ||
| dataset_id, | ||
| partition_id, | ||
| segment_id, | ||
| time_range, | ||
| fragment, | ||
| }) |
Member
Author
There was a problem hiding this comment.
this is the only business logic part of this pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
In this PR, we focus on
re_uri:?partition_idThe rest of the diff is essentially dealing with consequences, with some minor adjacent renames.