Skip to content

Commit 494ac48

Browse files
authored
Add sourcelink to enable source debugging of the nuget package (#4)
Add sourcelink to enable source debugging of the nuget package Remove SonarQube analysis from build - I've tried hard with SonarQube, but its just too annoying to use Fix the code coverage in the build. There were two problems, - "nuget restore" wasn't working properly, so switched to dotnet restore - I had to use `-register:Path64` argument for opencover. I'm not sure why, as `-register:User` used to work, and is supposed to do so without admin permissions.
1 parent 940fbed commit 494ac48

File tree

5 files changed

+25
-1038
lines changed

5 files changed

+25
-1038
lines changed

README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ A C# library for strongly typed Configuration with validation
44

55
[![Build status](https://ci.appveyor.com/api/projects/status/oujy1v19iwdba8e5?svg=true)](https://ci.appveyor.com/project/RESSoftwareTeam/configuration)
66

7-
[![Quality gate](https://sonarcloud.io/api/project_badges/quality_gate?project=res.configuration)](https://sonarcloud.io/dashboard?id=res.configuration)
8-
97
[![codecov](https://codecov.io/gh/resgroup/configuration/branch/master/graph/badge.svg)](https://codecov.io/gh/resgroup/configuration)
108

119
Example Usage (`Configuration` is the class provided by this repo)

RES.Configuration.Test/RES.Configuration.Test.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@
1111
<AppendRuntimeIdentifierToOutputPath>false</AppendRuntimeIdentifierToOutputPath>
1212
<BaseOutputPath>..\BuiltDLLs\</BaseOutputPath>
1313
<ProjectGuid>40b5b4a7-ad9a-4cec-b1cf-059482dfb9ce</ProjectGuid>
14-
<!-- only required for sonar qube, and only until they fix a .net core type issue https://jira.sonarsource.com/browse/SONARMSBRU-167 -->
1514
</PropertyGroup>
16-
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
15+
<PropertyGroup>
1716
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
17+
<DebugSymbols>True</DebugSymbols>
1818
<WarningsAsErrors />
1919
<NoWarn>1701;1702;1705;1125</NoWarn>
2020
</PropertyGroup>

0 commit comments

Comments
 (0)